Fixing TabViewItem sub-pixel bugs #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
team-Controls
ojhad
approved these changes
Jun 6, 2022
kmahone
pushed a commit
that referenced
this pull request
Jun 15, 2022
* Fixing TabViewItem sub-pixel bugs * Scope fix to post RS5 OS release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing selected tab view item's
To fix the vertical expansion:
TabViewItem::UpdateTabGeometry() needed to subtract 1 instead of 1 / scaleFactor from the item's ActualHeight to avoid the SelectedBackgroundPath element being too tall and cause infinite layout cycles when scale factor >= 3.0.
To fix the sub-pixel gap below the selected tab view item:
The only way I found was to use a small vertical TranslateTransform in the new TabViewItem::UpdateSelectedBackgroundPathTranslateTransform() method for the SelectedBackgroundPath element. It's pushed down to snap to a full pixel offset.
Fixes have been validated by our internal customer.