feat(web-components): refactor progress bar to use ElementInternals #31652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/update-progress-bar-for-element-internals
branch
2 times, most recently
from
8e9d16f to
4c9880b
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 11, 2024
change/@fluentui-web-components-6d07cdaf-1af6-4d87-9232-7dd09295ec30.json
Show resolved
Hide resolved
radium-v
reviewed
Jun 11, 2024
chrisdholt
force-pushed
the
users/chhol/update-progress-bar-for-element-internals
branch
3 times, most recently
from
a4c17e5 to
3c480f5
Compare
chrisdholt
force-pushed
the
users/chhol/update-progress-bar-for-element-internals
branch
from
3c480f5 to
82cc22a
Compare
…for-element-internals update progress bar for element internals
radium-v
approved these changes
Jun 11, 2024
chrisdholt
deleted the
users/chhol/update-progress-bar-for-element-internals
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 12, 2024
…escription * master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 12, 2024
* master: chore(react-list-preview): Add bundle size tests (microsoft#31658) applying package updates feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649) feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653) chore:(docs) New Component doc (microsoft#31611) style(react-nav-preview): fix formatting in barel file (microsoft#31671) feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652) chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581) fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580) chore: Remove recipes-react-components in favor of recipes package (microsoft#31647) feat: Add consistent start and finish lifecycle callbacks (microsoft#31644) chore(docs): Remove requirement of performance tests from epic template (microsoft#31662) chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579) docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637) docs(dev-env): update minimal node version (microsoft#31638)
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…icrosoft#31652) Co-authored-by: John Kreitlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Progress bar template included a heavy-handed
whendirective with slots for indicators and bound ARIA in the template.New Behavior
This removes that unnecessary configuration and migrates the component to leverage Element Internals.
Related Issue(s)