Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update progress bar for element internals #14

Merged
merged 3 commits into from
Jun 11, 2024
Merged

update progress bar for element internals #14

merged 3 commits into from
Jun 11, 2024

Conversation

radium-v
Copy link

Previous Behavior

  • Tests were synchronous
  • Explicit calls were needed to update the percentComplete
  • ARIA properties were being set in multiple places

New Behavior

  • Tests are async
  • percentComplete is now marked with @volatile, so any changes to properties used by it get set when those properties change
  • ARIA properties are automatically set when attributes change, and only when necessary

@chrisdholt chrisdholt merged commit 4035b73 into chrisdholt:users/chhol/update-progress-bar-for-element-internals Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radium-v @chrisdholt