Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(dev-env): update minimal node version #31638

Merged
merged 1 commit into from
Jun 11, 2024
Merged

docs(dev-env): update minimal node version #31638

merged 1 commit into from
Jun 11, 2024

Conversation

mainframev
Copy link
Contributor

We have node set on ^20.0.0 || ^22.0.0. Updated the dev-env doc according to it.

@mainframev mainframev requested review from a team as code owners June 10, 2024 12:46
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 37 36 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 643 672 5000
Button mount 321 300 5000
Field mount 1138 1155 5000
FluentProvider mount 727 719 5000
FluentProviderWithTheme mount 85 84 10
FluentProviderWithTheme virtual-rerender 37 36 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 80 74 10
MakeStyles mount 889 869 50000
Persona mount 1782 1773 5000
SpinButton mount 1379 1429 5000
SwatchPicker mount 1571 1611 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 217 194 1.12:1
VideoMinimalPerf.default 446 403 1.11:1
SkeletonMinimalPerf.default 204 186 1.1:1
FormMinimalPerf.default 236 216 1.09:1
ButtonSlotsPerf.default 328 303 1.08:1
FlexMinimalPerf.default 175 162 1.08:1
LayoutMinimalPerf.default 208 192 1.08:1
ListWith60ListItems.default 373 345 1.08:1
TreeWith60ListItems.default 87 81 1.07:1
ChatWithPopoverPerf.default 207 198 1.05:1
DividerMinimalPerf.default 213 203 1.05:1
RadioGroupMinimalPerf.default 279 265 1.05:1
SegmentMinimalPerf.default 203 193 1.05:1
TooltipMinimalPerf.default 1307 1248 1.05:1
CardMinimalPerf.default 313 300 1.04:1
HeaderMinimalPerf.default 212 203 1.04:1
ListMinimalPerf.default 308 296 1.04:1
RefMinimalPerf.default 109 105 1.04:1
StatusMinimalPerf.default 409 395 1.04:1
ImageMinimalPerf.default 230 223 1.03:1
InputMinimalPerf.default 554 538 1.03:1
ItemLayoutMinimalPerf.default 722 700 1.03:1
ListNestedPerf.default 326 315 1.03:1
MenuButtonMinimalPerf.default 974 950 1.03:1
CheckboxMinimalPerf.default 1140 1116 1.02:1
DropdownMinimalPerf.default 1424 1394 1.02:1
MenuMinimalPerf.default 507 499 1.02:1
PopupMinimalPerf.default 352 345 1.02:1
PortalMinimalPerf.default 86 84 1.02:1
ProviderMinimalPerf.default 200 197 1.02:1
SliderMinimalPerf.default 736 724 1.02:1
AlertMinimalPerf.default 164 163 1.01:1
AttachmentSlotsPerf.default 648 641 1.01:1
HeaderSlotsPerf.default 460 455 1.01:1
ListCommonPerf.default 386 382 1.01:1
RosterPerf.default 1565 1548 1.01:1
ReactionMinimalPerf.default 210 207 1.01:1
TableMinimalPerf.default 246 243 1.01:1
EmbedMinimalPerf.default 1891 1886 1:1
LabelMinimalPerf.default 218 217 1:1
LoaderMinimalPerf.default 196 196 1:1
ProviderMergeThemesPerf.default 655 656 1:1
TableManyItemsPerf.default 1101 1097 1:1
TextMinimalPerf.default 199 200 1:1
CustomToolbarPrototype.default 1491 1487 1:1
ButtonOverridesMissPerf.default 634 642 0.99:1
CarouselMinimalPerf.default 256 259 0.99:1
ChatDuplicateMessagesPerf.default 153 154 0.99:1
ChatMinimalPerf.default 434 438 0.99:1
DatepickerMinimalPerf.default 3555 3597 0.99:1
DialogMinimalPerf.default 441 446 0.99:1
DropdownManyItemsPerf.default 392 395 0.99:1
GridMinimalPerf.default 190 191 0.99:1
SplitButtonMinimalPerf.default 2227 2239 0.99:1
TextAreaMinimalPerf.default 277 281 0.99:1
AnimationMinimalPerf.default 287 293 0.98:1
IconMinimalPerf.default 371 377 0.98:1
ToolbarMinimalPerf.default 537 549 0.98:1
TreeMinimalPerf.default 469 480 0.98:1
AccordionMinimalPerf.default 81 85 0.95:1
ButtonMinimalPerf.default 88 93 0.95:1
AttachmentMinimalPerf.default 78 83 0.94:1
AvatarMinimalPerf.default 116 132 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 10, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 10, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@mainframev mainframev force-pushed the docs/update-setup-docs branch from b74b4d0 to 455e2cf Compare June 10, 2024 13:07
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 10, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 635 638 5000
Breadcrumb mount 1665 1642 1000
Checkbox mount 1696 1697 5000
CheckboxBase mount 1480 1483 5000
ChoiceGroup mount 3000 2995 5000
ComboBox mount 679 679 1000
CommandBar mount 6405 6448 1000
ContextualMenu mount 11338 11463 1000
DefaultButton mount 768 791 5000
DetailsRow mount 2204 2208 5000
DetailsRowFast mount 2188 2201 5000
DetailsRowNoStyles mount 2053 2068 5000
Dialog mount 2810 2793 1000
DocumentCardTitle mount 233 237 1000
Dropdown mount 2005 1965 5000
FocusTrapZone mount 1164 1132 5000
FocusZone mount 1095 1082 5000
GroupedList mount 37436 42074 2
GroupedList virtual-rerender 20137 20119 2
GroupedList virtual-rerender-with-unmount 50885 50509 2
GroupedListV2 mount 265 229 2
GroupedListV2 virtual-rerender 216 215 2
GroupedListV2 virtual-rerender-with-unmount 226 232 2
IconButton mount 1136 1148 5000
Label mount 332 343 5000
Layer mount 2773 2720 5000
Link mount 392 396 5000
MenuButton mount 974 976 5000
MessageBar mount 21552 21737 5000
Nav mount 2009 2039 1000
OverflowSet mount 798 771 5000
Panel mount 1804 1824 1000
Persona mount 772 752 1000
Pivot mount 914 908 1000
PrimaryButton mount 911 934 5000
Rating mount 4619 4667 5000
SearchBox mount 930 888 5000
Shimmer mount 1880 1921 5000
Slider mount 1333 1339 5000
SpinButton mount 2971 2999 5000
Spinner mount 403 392 5000
SplitButton mount 1895 1846 5000
Stack mount 404 420 5000
StackWithIntrinsicChildren mount 868 889 5000
StackWithTextChildren mount 2659 2669 5000
SwatchColorPicker mount 6332 6305 5000
TagPicker mount 1461 1434 5000
Text mount 377 372 5000
TextField mount 946 932 5000
ThemeProvider mount 836 840 5000
ThemeProvider virtual-rerender 575 577 5000
ThemeProvider virtual-rerender-with-unmount 1289 1285 5000
Toggle mount 607 613 5000
buttonNative mount 193 193 5000

@mainframev mainframev force-pushed the docs/update-setup-docs branch 3 times, most recently from eeb5142 to 1d4d39b Compare June 10, 2024 14:50
@mainframev mainframev force-pushed the docs/update-setup-docs branch from 1d4d39b to e7e7209 Compare June 10, 2024 20:34
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@mainframev mainframev merged commit 9b7d968 into microsoft:master Jun 11, 2024
21 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 12, 2024
@marcosmoura
Merge branch 'master' into fix/react-card/improve-alignment-when-no-d…
a28a71c 
…escription

* master:
  chore(react-list-preview): Add bundle size tests (microsoft#31658)
  applying package updates
  feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649)
  feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653)
  chore:(docs) New Component doc (microsoft#31611)
  style(react-nav-preview): fix formatting in barel file (microsoft#31671)
  feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652)
  chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581)
  fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667)
  chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580)
  chore: Remove recipes-react-components in favor of recipes package (microsoft#31647)
  feat: Add consistent start and finish lifecycle callbacks (microsoft#31644)
  chore(docs): Remove requirement of performance tests from epic template (microsoft#31662)
  chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579)
  docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637)
  docs(dev-env): update minimal node version (microsoft#31638)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 12, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
a0267b4 
* master:
  chore(react-list-preview): Add bundle size tests (microsoft#31658)
  applying package updates
  feat:react-nav-preview Add a handful of accessibility features for Nav (microsoft#31649)
  feat: refactor anchor-button to use element internals and anchor proxy element (microsoft#31653)
  chore:(docs) New Component doc (microsoft#31611)
  style(react-nav-preview): fix formatting in barel file (microsoft#31671)
  feat(web-components): refactor progress bar to use ElementInternals (microsoft#31652)
  chore(react-components): split react libraries in two (/library and /stories) - last batch (microsoft#31581)
  fix(scripts-beachball): ignore web-components packages from v8 release scope (microsoft#31667)
  chore(react-components): split react libraries in two (/library and /stories) - cxe-red /2nd batch (microsoft#31580)
  chore: Remove recipes-react-components in favor of recipes package (microsoft#31647)
  feat: Add consistent start and finish lifecycle callbacks (microsoft#31644)
  chore(docs): Remove requirement of performance tests from epic template (microsoft#31662)
  chore(react-components): split react libraries in two (/library and /stories) - cxe-red /1st batch (microsoft#31579)
  docs(react-swatch-picker): added SwatchPicker page to Component Mapping (microsoft#31637)
  docs(dev-env): update minimal node version (microsoft#31638)
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@mainframev @miroslavstastny
docs(dev-env): update minimal node version (microsoft#31638)
719bb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@Hotell Hotell Hotell left review comments

@layershifter layershifter layershifter approved these changes

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mainframev @fabricteam @Hotell @marcosmoura @layershifter