Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web-Components: cherry pick changes to new release #15637

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Web-Components: cherry pick changes to new release #15637

merged 1 commit into from
Oct 22, 2020

Conversation

joschect
Copy link
Contributor

@joschect joschect commented Oct 22, 2020 •
edited by ecraig12345
Loading

Cherry picks changes from the following PRs
#15313
#15382
#15397
#15429
#15502
#15611
#15509
#15435

Pull request checklist

Description of changes

(give an overview)

Focus areas to test

(optional)

@joschect joschect requested a review from chrisdholt October 22, 2020 00:13
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ede5493:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 877 868 5000
BaseButtonCompat mount 908 892 5000
Breadcrumb mount 159977 161545 5000
Checkbox mount 1448 1455 5000
CheckboxBase mount 1231 1215 5000
ChoiceGroup mount 4645 4567 5000
ComboBox mount 922 931 1000
CommandBar mount 22078 21810 1000
ContextualMenu mount 6147 6188 1000
DefaultButtonCompat mount 1149 1152 5000
DetailsRow mount 3617 3642 5000
DetailsRowFast mount 3655 3670 5000
DetailsRowNoStyles mount 3561 3489 5000
Dialog mount 1519 1488 1000
DocumentCardTitle mount 1855 1798 1000
Dropdown mount 3409 3485 5000
FocusTrapZone mount 1816 1842 5000
FocusZone mount 1785 1870 5000
IconButtonCompat mount 1724 1779 5000
Label mount 356 334 5000
Layer mount 1805 1793 5000
Link mount 463 465 5000
MenuButtonCompat mount 1415 1452 5000
MessageBar mount 2036 2119 5000
Nav mount 3277 3209 1000
OverflowSet mount 1040 1056 5000
Panel mount 1460 1487 1000
Persona mount 915 865 1000
Pivot mount 1487 1409 1000
PrimaryButtonCompat mount 1254 1264 5000
Rating mount 7291 7486 5000
SearchBox mount 1284 1288 5000
Shimmer mount 2500 2528 5000
Slider mount 1934 1888 5000
SpinButton mount 5294 4999 5000
Spinner mount 405 416 5000
SplitButtonCompat mount 3193 3140 5000
Stack mount 506 497 5000
StackWithIntrinsicChildren mount 1546 1589 5000
StackWithTextChildren mount 4607 4689 5000
SwatchColorPicker mount 11077 10094 5000
TagPicker mount 2805 2710 5000
TeachingBubble mount 11569 11553 5000
Text mount 418 441 5000
TextField mount 1406 1423 5000
ThemeProvider mount 2041 2022 5000
ThemeProvider virtual-rerender 643 640 5000
Toggle mount 806 789 5000
button mount 531 592 5000
buttonNative mount 117 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.5 0.88:1 2000 888
🦄 Button.Fluent 0.11 0.23 0.48:1 5000 562
🔧 Checkbox.Fluent 0.65 0.35 1.86:1 1000 650
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 820
🔧 Dropdown.Fluent 2.95 0.44 6.7:1 1000 2954
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 728
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 396
🔧 Slider.Fluent 1.7 0.46 3.7:1 1000 1699
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 368
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 600

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 412 365 1.13:1
SegmentMinimalPerf.default 401 364 1.1:1
PortalMinimalPerf.default 174 159 1.09:1
Slider.Fluent 1699 1564 1.09:1
RefMinimalPerf.default 257 238 1.08:1
GridMinimalPerf.default 398 371 1.07:1
AnimationMinimalPerf.default 437 412 1.06:1
AttachmentMinimalPerf.default 175 165 1.06:1
FlexMinimalPerf.default 329 310 1.06:1
LabelMinimalPerf.default 461 437 1.05:1
RadioGroupMinimalPerf.default 461 444 1.04:1
Tooltip.Fluent 600 578 1.04:1
ButtonMinimalPerf.default 187 182 1.03:1
CarouselMinimalPerf.default 475 462 1.03:1
DialogMinimalPerf.default 824 798 1.03:1
HeaderSlotsPerf.default 800 774 1.03:1
ListNestedPerf.default 592 573 1.03:1
ButtonUseCssPerf.default 843 825 1.02:1
DividerMinimalPerf.default 401 395 1.02:1
EmbedMinimalPerf.default 1978 1930 1.02:1
HeaderMinimalPerf.default 390 383 1.02:1
ListWith60ListItems.default 969 954 1.02:1
LoaderMinimalPerf.default 732 718 1.02:1
SliderMinimalPerf.default 1603 1570 1.02:1
SplitButtonMinimalPerf.default 3876 3813 1.02:1
IconMinimalPerf.default 680 668 1.02:1
TreeMinimalPerf.default 927 908 1.02:1
Avatar.Fluent 888 871 1.02:1
AccordionMinimalPerf.default 158 157 1.01:1
ButtonUseCssNestingPerf.default 1103 1094 1.01:1
ChatDuplicateMessagesPerf.default 422 419 1.01:1
CheckboxMinimalPerf.default 2891 2867 1.01:1
DropdownMinimalPerf.default 3006 2982 1.01:1
ListCommonPerf.default 664 660 1.01:1
PopupMinimalPerf.default 720 716 1.01:1
Button.Fluent 562 558 1.01:1
Checkbox.Fluent 650 641 1.01:1
Dialog.Fluent 820 814 1.01:1
ChatWithPopoverPerf.default 472 473 1:1
MenuMinimalPerf.default 874 870 1:1
MenuButtonMinimalPerf.default 1582 1580 1:1
ProviderMergeThemesPerf.default 2105 2115 1:1
ReactionMinimalPerf.default 422 424 1:1
TableMinimalPerf.default 431 433 1:1
TextAreaMinimalPerf.default 495 493 1:1
CustomToolbarPrototype.default 3977 3964 1:1
TooltipMinimalPerf.default 839 837 1:1
TreeWith60ListItems.default 213 214 1:1
VideoMinimalPerf.default 665 668 1:1
AttachmentSlotsPerf.default 1148 1157 0.99:1
ButtonOverridesMissPerf.default 1722 1738 0.99:1
ChatMinimalPerf.default 639 646 0.99:1
FormMinimalPerf.default 415 419 0.99:1
ImageMinimalPerf.default 397 399 0.99:1
ItemLayoutMinimalPerf.default 1279 1297 0.99:1
ListMinimalPerf.default 499 504 0.99:1
TableManyItemsPerf.default 2159 2184 0.99:1
CardMinimalPerf.default 560 569 0.98:1
DropdownManyItemsPerf.default 759 773 0.98:1
LayoutMinimalPerf.default 425 433 0.98:1
ProviderMinimalPerf.default 1024 1044 0.98:1
SkeletonMinimalPerf.default 431 439 0.98:1
ToolbarMinimalPerf.default 955 972 0.98:1
Dropdown.Fluent 2954 3022 0.98:1
Image.Fluent 396 405 0.98:1
InputMinimalPerf.default 1311 1357 0.97:1
Text.Fluent 368 379 0.97:1
AvatarMinimalPerf.default 470 491 0.96:1
BoxMinimalPerf.default 371 385 0.96:1
StatusMinimalPerf.default 722 751 0.96:1
Icon.Fluent 728 755 0.96:1
ButtonSlotsPerf.default 595 628 0.95:1
AlertMinimalPerf.default 315 344 0.92:1

@size-auditor
Copy link

size-auditor bot commented Oct 22, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bf6bf4ca481644d4661ee772aa8cb024d261d34d (build)

@joschect joschect changed the title cherry pick a large amount of web-components changes Web-Components: cherry pick changes to new release Oct 22, 2020
@xugao xugao merged commit 76cc354 into microsoft:master Oct 22, 2020
@khmakoto khmakoto mentioned this pull request Oct 22, 2020
Closed
40 tasks
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@joschect
cherry pick a large amount of web-components changes (microsoft#15637)
2d5e996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@khmakoto khmakoto khmakoto approved these changes

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@xugao xugao xugao approved these changes

Assignees

@tomi-msft tomi-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joschect @msft-github-bot @xugao @ecraig12345 @khmakoto @chrisdholt @tomi-msft