Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web-components yarn test --production #15611

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

xugao
Copy link
Contributor

@xugao xugao commented Oct 20, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

API extractor throws error with --production arg:

2020-10-20T12:09:48.0010885Z ERR! ERROR DETECTED IN @fluentui/web-components test
2020-10-20T12:09:48.0011307Z ERR! started
2020-10-20T12:09:48.0011684Z ERR! hash: 731f4602c5e194474e5562c5463286a8841310cf, cache hit? false
2020-10-20T12:09:48.0012723Z ERR! Running /mnt/work/_tool/node/12.18.3/x64/bin/npm run test -- --production
2020-10-20T12:09:48.0014084Z ERR! npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1603195776022-0.339572909257273/node but npm is using /mnt/work/_tool/node/12.18.3/x64/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.
2020-10-20T12:09:48.0015267Z ERR! > @fluentui/[email protected] test /mnt/work/3/s/packages/web-components
2020-10-20T12:09:48.0016187Z ERR! > yarn test-chrome:verbose && yarn doc:ci "--production"
2020-10-20T12:09:48.0017191Z ERR! $ karma start karma.conf.js --browsers=ChromeHeadlessOpt --single-run --coverage --reporter=mocha
2020-10-20T12:09:48.0017663Z ERR! START:
2020-10-20T12:09:48.0018271Z ERR! �[34mℹ�[39m �[90m「wdm」�[39m: Compiled successfully.
2020-10-20T12:09:48.0018968Z ERR! �[34mℹ�[39m �[90m「wdm」�[39m: Compiling...
2020-10-20T12:09:48.0019943Z ERR! �[34mℹ�[39m �[90m「wdm」�[39m: Compiled successfully.
2020-10-20T12:09:48.0020923Z ERR!   The fluent-badge component
2020-10-20T12:09:48.0021558Z ERR!     ✔ adds its appearance as a host class
2020-10-20T12:09:48.0021943Z ERR! TOTAL: 1 SUCCESS
2020-10-20T12:09:48.0022367Z ERR! =============================== Coverage summary ===============================
2020-10-20T12:09:48.0022824Z ERR! Statements   : 72.33% ( 149/206 )
2020-10-20T12:09:48.0023193Z ERR! Branches     : 10% ( 1/10 )
2020-10-20T12:09:48.0023553Z ERR! Functions    : 5.36% ( 3/56 )
2020-10-20T12:09:48.0023898Z ERR! Lines        : 94.9% ( 149/157 )
2020-10-20T12:09:48.0025371Z ERR! ================================================================================
2020-10-20T12:09:48.0025795Z ERR! 
2020-10-20T12:09:48.0026192Z ERR! Finished in 0.01 secs / 0.001 secs @ 12:09:46 GMT+0000 (Coordinated Universal Time)
2020-10-20T12:09:48.0026592Z ERR! 
2020-10-20T12:09:48.0026847Z ERR! SUMMARY:
2020-10-20T12:09:48.0027452Z ERR! ✔ 1 test completed
2020-10-20T12:09:48.0028194Z ERR! $ api-extractor run --local --production
2020-10-20T12:09:48.0028856Z ERR! api-extractor 7.7.1  - https://api-extractor.com/
2020-10-20T12:09:48.0029603Z ERR! usage: api-extractor run [-h] [-c FILE] [-l] [-v] [--diagnostics]
2020-10-20T12:09:48.0030346Z ERR!                          [--typescript-compiler-folder PATH]
2020-10-20T12:09:48.0030732Z ERR! 
2020-10-20T12:09:48.0031407Z ERR! api-extractor run: error: Unrecognized arguments: --production.
2020-10-20T12:09:48.0031920Z ERR! error Command failed with exit code 2.

Failed build here

Focus areas to test

(optional)

@xugao xugao requested a review from chrisdholt as a code owner October 20, 2020 16:09
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 20, 2020
@xugao xugao requested a review from ecraig12345 October 20, 2020 16:10
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 875 826 5000
BaseButton mount 919 915 5000
Breadcrumb mount 41945 42605 5000
ButtonNext mount 662 682 5000
Checkbox mount 1526 1528 5000
CheckboxBase mount 1271 1310 5000
ChoiceGroup mount 4966 4958 5000
ComboBox mount 932 936 1000
CommandBar mount 7725 7718 1000
ContextualMenu mount 14330 14489 1000
DefaultButton mount 1132 1122 5000
DetailsRow mount 3677 3700 5000
DetailsRowFast mount 3637 3678 5000
DetailsRowNoStyles mount 3500 3440 5000
Dialog mount 1483 1521 1000
DocumentCardTitle mount 1840 1840 1000
Dropdown mount 2585 2541 5000
FocusTrapZone mount 1767 1733 5000
FocusZone mount 1799 1835 5000
IconButton mount 1781 1784 5000
Label mount 355 351 5000
Layer mount 2033 2061 5000
Link mount 447 450 5000
MenuButton mount 1487 1460 5000
MessageBar mount 2128 2076 5000
Nav mount 3305 3238 1000
OverflowSet mount 1394 1410 5000
Panel mount 1437 1511 1000
Persona mount 872 854 1000
Pivot mount 1442 1428 1000
PrimaryButton mount 1317 1291 5000
Rating mount 7663 7688 5000
SearchBox mount 1298 1302 5000
Shimmer mount 2558 2525 5000
Slider mount 1468 1522 5000
SpinButton mount 5004 5046 5000
Spinner mount 430 435 5000
SplitButton mount 3218 3183 5000
Stack mount 516 515 5000
StackWithIntrinsicChildren mount 1558 1585 5000
StackWithTextChildren mount 4716 4683 5000
SwatchColorPicker mount 10330 10364 5000
TagPicker mount 2775 2673 5000
TeachingBubble mount 51482 51373 5000
Text mount 435 449 5000
TextField mount 1424 1393 5000
ThemeProvider mount 1698 1691 5000
ThemeProvider virtual-rerender 618 633 5000
Toggle mount 821 842 5000
button mount 105 110 5000

@xugao xugao merged commit 35627bb into microsoft:7.0 Oct 20, 2020
@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 03eece78b4583e0c34e42b159a954a8f64748be3 (build)

@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants