Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WC button font inheritance issues #15435

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@chrisdholt chrisdholt self-assigned this Oct 8, 2020
@msft-github-bot msft-github-bot added Fabric 7 web-components needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Oct 8, 2020
@chrisdholt chrisdholt changed the title Users/chhol/button font inheritance issues fix WC button font inheritance issues Oct 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 59eb138:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 885 910 5000
BaseButton mount 984 1010 5000
Breadcrumb mount 41751 41988 5000
ButtonNext mount 595 594 5000
Checkbox mount 1656 1663 5000
CheckboxBase mount 1380 1402 5000
ChoiceGroup mount 5169 5226 5000
ComboBox mount 991 986 1000
CommandBar mount 7830 7869 1000
ContextualMenu mount 13658 13420 1000
DefaultButton mount 1247 1200 5000
DetailsRow mount 3842 3782 5000
DetailsRowFast mount 3814 3864 5000
DetailsRowNoStyles mount 3608 3713 5000
Dialog mount 1544 1533 1000
DocumentCardTitle mount 1863 1849 1000
Dropdown mount 2770 2789 5000
FocusTrapZone mount 1734 1754 5000
FocusZone mount 1896 1860 5000
IconButton mount 1953 1920 5000
Label mount 348 366 5000
Layer mount 2067 2073 5000
Link mount 473 492 5000
MenuButton mount 1580 1571 5000
MessageBar mount 2174 2130 5000
Nav mount 3443 3501 1000
OverflowSet mount 1534 1489 5000
Panel mount 1504 1530 1000
Persona mount 860 889 1000
Pivot mount 1536 1497 1000
PrimaryButton mount 1371 1376 5000
Rating mount 8157 8157 5000
SearchBox mount 1393 1383 5000
Shimmer mount 2729 2745 5000
Slider mount 1611 1565 5000
SpinButton mount 5306 5348 5000
Spinner mount 430 441 5000
SplitButton mount 3371 3364 5000
Stack mount 546 544 5000
StackWithIntrinsicChildren mount 2030 2064 5000
StackWithTextChildren mount 5304 5319 5000
SwatchColorPicker mount 11068 10885 5000
TagPicker mount 2883 2879 5000
TeachingBubble mount 50576 50608 5000
Text mount 450 458 5000
TextField mount 1549 1536 5000
ThemeProvider mount 1734 1696 5000
ThemeProvider virtual-rerender 629 650 5000
Toggle mount 871 872 5000
button mount 120 119 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.51 0.98:1 2000 994
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 670
🔧 Checkbox.Fluent 0.69 0.39 1.77:1 1000 693
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 863
🔧 Dropdown.Fluent 3.01 0.52 5.79:1 1000 3007
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 771
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 459
🔧 Slider.Fluent 1.66 0.39 4.26:1 1000 1656
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 417
🦄 Tooltip.Fluent 0.12 16.46 0.01:1 5000 603

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 179 0 Infinity:1
AlertMinimalPerf.default 342 0 Infinity:1
AnimationMinimalPerf.default 456 0 Infinity:1
AttachmentMinimalPerf.default 209 0 Infinity:1
AvatarMinimalPerf.default 532 0 Infinity:1
BoxMinimalPerf.default 422 0 Infinity:1
ButtonMinimalPerf.default 210 0 Infinity:1
ButtonOverridesMissPerf.default 1800 0 Infinity:1
ButtonSlotsPerf.default 659 0 Infinity:1
ButtonUseCssPerf.default 926 0 Infinity:1
ButtonUseCssNestingPerf.default 1181 0 Infinity:1
CardMinimalPerf.default 660 0 Infinity:1
CarouselMinimalPerf.default 537 0 Infinity:1
ChatDuplicateMessagesPerf.default 450 0 Infinity:1
ChatMinimalPerf.default 721 0 Infinity:1
CheckboxMinimalPerf.default 3067 0 Infinity:1
DialogMinimalPerf.default 882 0 Infinity:1
DividerMinimalPerf.default 448 0 Infinity:1
DropdownManyItemsPerf.default 862 0 Infinity:1
DropdownMinimalPerf.default 3022 0 Infinity:1
EmbedMinimalPerf.default 2136 0 Infinity:1
FormMinimalPerf.default 519 0 Infinity:1
GridMinimalPerf.default 391 0 Infinity:1
HeaderMinimalPerf.default 449 0 Infinity:1
HeaderSlotsPerf.default 927 0 Infinity:1
ImageMinimalPerf.default 474 0 Infinity:1
InputMinimalPerf.default 1387 0 Infinity:1
ItemLayoutMinimalPerf.default 1458 0 Infinity:1
LabelMinimalPerf.default 477 0 Infinity:1
LayoutMinimalPerf.default 474 0 Infinity:1
ListCommonPerf.default 749 0 Infinity:1
ListMinimalPerf.default 572 0 Infinity:1
ListNestedPerf.default 647 0 Infinity:1
ListWith60ListItems.default 1002 0 Infinity:1
LoaderMinimalPerf.default 824 0 Infinity:1
MenuMinimalPerf.default 993 0 Infinity:1
MenuButtonMinimalPerf.default 1717 0 Infinity:1
PopupMinimalPerf.default 742 0 Infinity:1
ProviderMergeThemesPerf.default 2074 0 Infinity:1
RadioGroupMinimalPerf.default 507 0 Infinity:1
ReactionMinimalPerf.default 492 0 Infinity:1
SegmentMinimalPerf.default 415 0 Infinity:1
SkeletonMinimalPerf.default 499 0 Infinity:1
SliderMinimalPerf.default 1609 0 Infinity:1
SplitButtonMinimalPerf.default 4098 0 Infinity:1
StatusMinimalPerf.default 851 0 Infinity:1
IconMinimalPerf.default 788 0 Infinity:1
TableManyItemsPerf.default 2507 0 Infinity:1
TableMinimalPerf.default 498 0 Infinity:1
TextMinimalPerf.default 429 0 Infinity:1
TextAreaMinimalPerf.default 578 0 Infinity:1
CustomToolbarPrototype.default 4061 0 Infinity:1
ToolbarMinimalPerf.default 1130 0 Infinity:1
TooltipMinimalPerf.default 899 0 Infinity:1
TreeMinimalPerf.default 1018 0 Infinity:1
TreeWith60ListItems.default 233 0 Infinity:1
VideoMinimalPerf.default 712 0 Infinity:1
Avatar.Fluent 994 0 Infinity:1
Button.Fluent 670 0 Infinity:1
Checkbox.Fluent 693 0 Infinity:1
Dialog.Fluent 863 0 Infinity:1
Image.Fluent 459 0 Infinity:1
Slider.Fluent 1656 0 Infinity:1
Tooltip.Fluent 603 0 Infinity:1
Dropdown.Fluent 3007 1 3007:1
AttachmentSlotsPerf.default 1243 1 1243:1
ProviderMinimalPerf.default 1062 1 1062:1
Icon.Fluent 771 1 771:1
ChatWithPopoverPerf.default 504 1 504:1
Text.Fluent 417 1 417:1
FlexMinimalPerf.default 364 1 364:1
RefMinimalPerf.default 249 1 249:1
PortalMinimalPerf.default 177 1 177:1

@size-auditor
Copy link

size-auditor bot commented Oct 8, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 2f6ebac

Possible causes

  • The baseline build 2f6ebac is broken
  • The Size Auditor run for the baseline build 2f6ebac was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@chrisdholt chrisdholt merged commit 7bac606 into microsoft:7.0 Oct 9, 2020
@chrisdholt chrisdholt deleted the users/chhol/button-font-inheritance-issues branch October 9, 2020 05:25
@msft-github-bot
Copy link
Contributor

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@xugao xugao removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants