feat(web-components): update package name to align with @fluentui and update component namespace #14345
Conversation
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
from
a55e3cf to
a10c20e
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be1882b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ff937a44d7f5816532ff9894daac0d247cb778f5 (build) |
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
from
a10c20e to
a61c513
Compare
chrisdholt
changed the title
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
from
a61c513 to
2358529
Compare
| "description": "A library of Fluent Web Components", | ||
| "sideEffects": false, | ||
| "version": "1.6.0", | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
We should start this as 0.1.0 or we'll have some issues representing breaking vs. non-breaking changes.
There was a problem hiding this comment.
@dzearing I'm making an assumption here on how beachball works, but perhaps you or @ecraig12345 can confirm for me so I can resolve this :).
I reset this to 0.0.1 and targeted my change request as a minor version change. I'm assuming that should update the package.json here to be 0.1.0 - is that correct?
|
Some follow-up notes for reviewers based on a conversation that @chrisdholt and I had. We're changing the element names to align with fluent branding and also to prevent a potential breaking change to default names in the future. Once we implement the new provider design outlined here we'll be able to give control over the prefix to end users. So, if someone was using <script type="module" src="..." data-prefix="fast"></script>
<script type="module" src="..." data-prefix="fluent"></script>
<script type="module" src="..." data-prefix="material"></script>
<script type="module" src="..." data-prefix="ui"></script>
...The single file script build would set up a default provider configuration, checking its own script tag to see if a prefix was configured for the provider. Additionally, based on some conversations with Graph, we'll be looking into whether the new provider model could support lazily creating a provider if one is not defined. In this case, the prefix would default to |
| "description": "A library of Fluent Web Components", | ||
| "sideEffects": false, | ||
| "version": "1.6.0", | ||
| "version": "0.0.1", |
There was a problem hiding this comment.
yup, the minor will update this to 0.1.0.
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
2 times, most recently
from
a5d79b0 to
c9a43d2
Compare
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
2 times, most recently
from
3a09b62 to
c9a43d2
Compare
|
@layershifter @miroslavstastny @levithomason Wanted to give you a heads up here. The build errors in this PR are all in I believe something here is causing react-northstar to build with a newer typescript build, but I'm not sure. I know that if I clone a fresh enlistment and open VSCode (defaulting to TS 3.9.x) to Still parsing why TypeScript version has changed here; we thought it was an incorrectly defined |
chrisdholt
force-pushed
the
users/chhol/update-web-components-package-name
branch
from
c9a43d2 to
d49aa4c
Compare
Perf Analysis
All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
🎉 Handy links: |
… update component namespace (microsoft#14345) * feat: update web components package namespace and opt-in to change and publish process * update the names for controls to fluent * update version as this package is net new * Change files * add api report
Pull request checklist
$ yarn changeDescription of changes
This PR updates the package name to align with the FluentUI namespace.