Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Update web-components package to use the @fluentui/ namespace #14343

Closed
chrisdholt opened this issue Aug 4, 2020 · 4 comments · Fixed by #14345
Closed

Proposal: Update web-components package to use the @fluentui/ namespace #14343

chrisdholt opened this issue Aug 4, 2020 · 4 comments · Fixed by #14345

Comments

@chrisdholt
Copy link
Member

chrisdholt commented Aug 4, 2020

Currently the web components package is under the global @microsoft/ namespace with a package name of @microsoft/fast-components-msft. Aside from the obvious of not sharing the existing @fluentui/ namespace, there are also publishing considerations that updating the package name will resolve. This package was previously published using lerna, which would rev the package version, create a changelog, fire off tags and force push a publish commit to master. I don't think that is a wise publishing method to inject into the workflow here. Additionally, there are permissions issues with that approach.

It seems that the fastest and safest way to address this issue would be to update the namespace and include the Web Components package as part of the publish process.

Proposed package name: @fluentui/web-components. Ideally, I like the concept of simply calling these "components" rather than specifying web components, but I understand with existing conventions that could cause confusion. :)

@chrisdholt chrisdholt self-assigned this Aug 4, 2020
@chrisdholt chrisdholt changed the title Proposal: Update web-components package to use the @fluent/ namespace Proposal: Update web-components package to use the @fluentui/ namespace Aug 4, 2020
@dzearing
Copy link
Member

dzearing commented Aug 4, 2020

Totally support @FluentUI namespace rename, asap.

I would prefer to keep the package web-components, too many frameworks call things components and that at least spells out what's going on.

@EisenbergEffect
Copy link
Contributor

If Fluent UI has been publishing under @fluentui, then I think we should make the change. @chrisdholt We'll want to coordinate the first publish under this name with an update to our fast site documentation. I can prepare those changes, given a day or so notice.

@chrisdholt
Copy link
Member Author

@EisenbergEffect I think we'll move quickly here and per @dzearing the publish happens nightly. If you'd like, I can do a pass on our end to wrap this work and coordinate since it's getting later in the day where you're at.

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14345, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants