Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update web-components README npm badge #14523

Merged
merged 1 commit into from
Aug 28, 2020
Merged

docs: Update web-components README npm badge #14523

merged 1 commit into from
Aug 28, 2020

Conversation

amis92
Copy link
Contributor

@amis92 amis92 commented Aug 14, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

web-components package's README npm badge updated with fluentui namespace,
still had microsoft as a leftover after #14345.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8335e4c:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 14, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 886 890 5000
ButtonNext mount 571 572 5000
Checkbox mount 1516 1564 5000
CheckboxBase mount 1260 1271 5000
CheckboxNext mount 1662 1701 5000
ChoiceGroup mount 5090 4929 5000
ComboBox mount 939 902 1000
CommandBar mount 7626 7708 1000
ContextualMenu mount 13533 13738 1000
DefaultButton mount 1134 1126 5000
DetailsRow mount 3540 3606 5000
DetailsRowFast mount 3499 3587 5000
DetailsRowNoStyles mount 3380 3423 5000
Dialog mount 1492 1512 1000
DocumentCardTitle mount 1827 1808 1000
Dropdown mount 2650 2581 5000
FocusZone mount 1830 1874 5000
IconButton mount 1696 1741 5000
Label mount 339 347 5000
Link mount 430 447 5000
LinkNext mount 492 469 5000
MenuButton mount 1457 1430 5000
Nav mount 3243 3166 1000
Panel mount 1449 1448 1000
Persona mount 839 821 1000
Pivot mount 1405 1430 1000
PivotNext mount 1433 1372 1000
PrimaryButton mount 1274 1265 5000
SearchBox mount 1260 1275 5000
SearchBoxNext mount 1308 1336 5000
Slider mount 1460 1456 5000
SliderNext mount 1877 1938 5000
SpinButton mount 5006 4866 5000
SpinButtonNext mount 5006 5141 5000
Spinner mount 425 403 5000
SplitButton mount 3068 3090 5000
Stack mount 545 550 5000
StackWithIntrinsicChildren mount 1933 1951 5000
StackWithTextChildren mount 5002 4992 5000
TagPicker mount 2698 2737 5000
Text mount 420 411 5000
TextField mount 1368 1350 5000
ThemeProvider mount 2900 2977 5000
ThemeProvider virtual-rerender 452 455 5000
Toggle mount 832 817 5000
ToggleNext mount 824 830 5000
button mount 122 115 5000

Perf Analysis (Fluent)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 116 42 2.76:1 analysis
ButtonUseCssPerf.default 50 44 1.14:1 analysis
ListCommonPerf.default 656 935 0.7:1 analysis
ListNestedPerf.default 604 878 0.69:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.48 0.92:1 2000 876
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 545
🔧 Checkbox.Fluent 0.62 0.36 1.72:1 1000 617
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 781
🔧 Dropdown.Fluent 2.95 0.47 6.28:1 1000 2952
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 682
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 362
🔧 Slider.Fluent 1.6 0.35 4.57:1 1000 1597
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 351
🦄 Tooltip.Fluent 0.11 17.63 0.01:1 5000 529

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 59 47 1.26:1
LoaderMinimalPerf.default 787 708 1.11:1
AlertMinimalPerf.default 304 280 1.09:1
ChatWithPopoverPerf.default 487 447 1.09:1
HeaderMinimalPerf.default 371 341 1.09:1
AttachmentMinimalPerf.default 158 146 1.08:1
LayoutMinimalPerf.default 400 369 1.08:1
AttachmentSlotsPerf.default 1163 1082 1.07:1
BoxMinimalPerf.default 347 324 1.07:1
TextMinimalPerf.default 344 322 1.07:1
LabelMinimalPerf.default 411 386 1.06:1
Text.Fluent 351 331 1.06:1
GridMinimalPerf.default 327 312 1.05:1
ImageMinimalPerf.default 350 332 1.05:1
SkeletonMinimalPerf.default 391 374 1.05:1
TableMinimalPerf.default 385 368 1.05:1
Dialog.Fluent 781 741 1.05:1
AccordionMinimalPerf.default 144 139 1.04:1
CardMinimalPerf.default 548 526 1.04:1
FlexMinimalPerf.default 286 274 1.04:1
PopupMinimalPerf.default 674 650 1.04:1
ProviderMinimalPerf.default 959 922 1.04:1
RadioGroupMinimalPerf.default 422 407 1.04:1
ReactionMinimalPerf.default 385 369 1.04:1
RefMinimalPerf.default 212 203 1.04:1
VideoMinimalPerf.default 596 575 1.04:1
AnimationMinimalPerf.default 394 384 1.03:1
CarouselMinimalPerf.default 468 455 1.03:1
DialogMinimalPerf.default 765 742 1.03:1
DropdownMinimalPerf.default 3012 2919 1.03:1
MenuButtonMinimalPerf.default 1539 1496 1.03:1
SplitButtonMinimalPerf.default 3755 3663 1.03:1
Avatar.Fluent 876 849 1.03:1
Button.Fluent 545 530 1.03:1
Icon.Fluent 682 665 1.03:1
Image.Fluent 362 352 1.03:1
ButtonSlotsPerf.default 611 599 1.02:1
DividerMinimalPerf.default 351 343 1.02:1
InputMinimalPerf.default 1321 1301 1.02:1
MenuMinimalPerf.default 825 811 1.02:1
ProviderMergeThemesPerf.default 1987 1955 1.02:1
IconMinimalPerf.default 645 630 1.02:1
TableManyItemsPerf.default 2191 2144 1.02:1
CustomToolbarPrototype.default 3818 3759 1.02:1
TreeMinimalPerf.default 852 833 1.02:1
ButtonMinimalPerf.default 162 160 1.01:1
ChatDuplicateMessagesPerf.default 415 410 1.01:1
DropdownManyItemsPerf.default 779 772 1.01:1
PortalMinimalPerf.default 127 126 1.01:1
TextAreaMinimalPerf.default 449 446 1.01:1
ToolbarMinimalPerf.default 913 904 1.01:1
Tooltip.Fluent 529 526 1.01:1
EmbedMinimalPerf.default 1877 1878 1:1
FormMinimalPerf.default 380 381 1:1
HeaderSlotsPerf.default 749 750 1:1
SegmentMinimalPerf.default 322 325 0.99:1
SliderMinimalPerf.default 1582 1593 0.99:1
StatusMinimalPerf.default 648 653 0.99:1
TooltipMinimalPerf.default 766 771 0.99:1
Dropdown.Fluent 2952 2993 0.99:1
Slider.Fluent 1597 1613 0.99:1
CheckboxMinimalPerf.default 2808 2871 0.98:1
ListMinimalPerf.default 467 476 0.98:1
AvatarMinimalPerf.default 460 475 0.97:1
ChatMinimalPerf.default 577 594 0.97:1
ItemLayoutMinimalPerf.default 1225 1271 0.96:1
TreeWith60ListItems.default 202 212 0.95:1
Checkbox.Fluent 617 655 0.94:1
ListWith60ListItems.default 925 1059 0.87:1

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 32c11c6179cf800198ea3b36770661b5da9f06a3 (build)

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @amis92! Can you try and take the latest changes from master and rebase with your branch? I think that'll get the build passing and we can get this in!

@amis92
Copy link
Contributor Author

amis92 commented Aug 18, 2020

@chrisdholt I did as you asked.

Although I have to say, it was less than optimal - I had to checkout the repo :( If not for the huge number of checks and diagnostics, I'd have opened another PR ;D

@amis92
Copy link
Contributor Author

amis92 commented Aug 18, 2020

Man. Dear maintainers, please reconsider your checks - it's not a great experience to have your one-line documentation PR cause theoretical perf regressions and not pass CI build. 🙄

@chrisdholt
Copy link
Member

@amis92 I'll dig in here - I don't think the perf issue is the cause. I ran into several similar failures with a PR yesterday. We'll get this addressed and get your PR in. Thanks for the contribution and the feedback!

@ecraig12345
Copy link
Member

Merging this since it's clearly not related to any of the build failures.

@ecraig12345 ecraig12345 merged commit 8ecb200 into microsoft:master Aug 28, 2020
@amis92
Copy link
Contributor Author

amis92 commented Aug 28, 2020

Thank you! 🙏 :)

@amis92 amis92 deleted the patch-1 branch August 28, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants