-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update web-components README npm badge #14523
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8335e4c:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 32c11c6179cf800198ea3b36770661b5da9f06a3 (build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @amis92! Can you try and take the latest changes from master and rebase with your branch? I think that'll get the build passing and we can get this in!
@chrisdholt I did as you asked. Although I have to say, it was less than optimal - I had to checkout the repo :( If not for the huge number of checks and diagnostics, I'd have opened another PR ;D |
Man. Dear maintainers, please reconsider your checks - it's not a great experience to have your one-line documentation PR cause theoretical perf regressions and not pass CI build. 🙄 |
@amis92 I'll dig in here - I don't think the perf issue is the cause. I ran into several similar failures with a PR yesterday. We'll get this addressed and get your PR in. Thanks for the contribution and the feedback! |
Merging this since it's clearly not related to any of the build failures. |
Thank you! 🙏 :) |
Pull request checklist
$ yarn change
Description of changes
web-components
package's README npm badge updated withfluentui
namespace,still had
microsoft
as a leftover after #14345.