Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug_FailFast configuration #3267

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Add Debug_FailFast configuration #3267

merged 3 commits into from
Jun 20, 2024

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Jun 20, 2024

Summary of the pull request

Turning FailFastOnErrors back on again (#3244) exposed a new crash, and we expect more as we iron things out. Instead of continuing to turn it off and on, this change creates a new Debug configuration called Debug_FailFast, which developers can choose to use when it works for them.

Most changes done by Visual Studio, except defining and using the DEBUG_FAILFAST constant.

References and relevant issues

#3019

Validation steps performed

Validated locally that Debug and Debug_FailFast both had the failfast settings we expect.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
  • Telemetry compliance tasks completed for added/updated events

@krschau krschau added this to the Dev Home 0.16 milestone Jun 20, 2024
@jsidewhite
Copy link
Member

Instead of having a configuration, can you just unconditionally set
DebugSettings.FailFastOnErrors = true;
in each component that is currently clean? (then unset it when it's done.)

(or better - set it false in each messy component and set to true at the end of it.)

Copy link
Member

@jsidewhite jsidewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau merged commit 01a314b into main Jun 20, 2024
4 checks passed
@krschau krschau deleted the user/krschau/debug-failfast branch June 20, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants