Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FailFastOnErrors property to better improve error diagnosis #3019

Open
2 of 4 tasks
adrastogi opened this issue May 30, 2024 · 1 comment
Open
2 of 4 tasks
Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Feature New feature or request

Comments

@adrastogi
Copy link
Contributor

adrastogi commented May 30, 2024

Suggested new feature or improvement

Set the FailFastOnErrors property so that XAML errors will result in immediate crashes (thereby enabling easier diagnosis).

Scenario

This is feedback from the WinAppSDK folks who helped investigate some recent bugs, so filing this issue to help track it. The idea is to use the property documented below in Dev Home so that it is easier to find errors earlier and with more context, which is especially useful in cases where those errors might otherwise be ignored.

https://learn.microsoft.com/en-us/uwp/api/windows.ui.xaml.debugsettings.failfastonerrors?view=winrt-22621

Additional details

The documentation indicates that this can be set for apps in the Store as well. So we would likely want to do this in a progressive fashion (e.g., set this property, run through our test scenarios and see what crashes get surfaced, fix those, test again, etc.). Once we have a good baseline, we could consider enabling this globally in published versions of the application.

Tasks

Preview Give feedback
  1. Area-Core Issue-Bug Priority-2 Resolution-Fix-Available
  2. Area-Customization Issue-Bug Priority-2
@adrastogi adrastogi added the Issue-Feature New feature or request label May 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label May 30, 2024
@adrastogi adrastogi changed the title Enable FailFastOnErrors property to better improve crash diagnosis Enable FailFastOnErrors property to better improve error diagnosis May 30, 2024
@krschau krschau added Area-Core Related to Dev Home as a whole 🏠 and removed Needs-Triage New issue that the core contributors need to triage labels May 30, 2024
@krschau krschau added this to the Dev Home 0.15 milestone May 30, 2024
@krschau krschau modified the milestones: Dev Home 0.15, Dev Home 0.16 Jun 10, 2024
@krschau
Copy link
Collaborator

krschau commented Jun 11, 2024

Besides the errors on startup and shutdown, I'm seeing one after clicking "set up local machine" in Machine configuration, although it doesn't bring down DH.

@krschau krschau removed this from the Dev Home 0.16 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Core Related to Dev Home as a whole 🏠 Issue-Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants