Enable FailFastOnErrors for debug builds #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
requested review from
dhoehna,
adrastogi,
guimafelipe,
dkbennett,
EricJohnson327 and
AmelBawa-msft
|
Have we resolved the failfast on close that we were seeing before? |
I talked to the WinUI team and opened a bug on them for the crash (bug number is in the code). Their advice in the meantime was to turn off failfast before we hit the crash and they agreed that MainWindow.Closed was a good time to do it. (Alternatively, we could TerminateProcess but I'm worried about stomping over someone's shutdown logic.) We don't hit the shutdown crash with this mitigation. |
vineeththomasalex
approved these changes
Jun 19, 2024
dhoehna
approved these changes
Jun 19, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
We want to enable FailFastOnErrors for better diagnostics (#3019). There is currently a XAML bug causing a crash on shutdown when it is on. To work around this bug, turn off FailFastOnErrors before we hit the error. We may miss out on some diagnostics during shutdown, but we're not very concerned with those. Turning it off during MainWindow.Closed() at the advice of the WinUI team.
Validation steps performed
Validated locally with a debug build.
PR checklist