Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overloads coming from overridable interfaces #1458

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix overloads coming from overridable interfaces #1458

merged 2 commits into from
Dec 4, 2024

Conversation

sylveon
Copy link
Contributor

@sylveon sylveon commented Nov 23, 2024

Fixes #1457

@sylveon sylveon mentioned this pull request Nov 23, 2024
Closed
dlech added a commit to pywinrt/TestWinRT that referenced this pull request Nov 24, 2024
@dlech
TestComponent: Add OverloadClass
edf5837 
Copied from microsoft/cppwinrt#1458
dlech added a commit to pywinrt/TestWinRT that referenced this pull request Nov 24, 2024
@dlech
TestComponent: Add OverloadClass
0c53011 
Copied from microsoft/cppwinrt#1458
dlech added a commit to pywinrt/TestWinRT that referenced this pull request Nov 24, 2024
@dlech
TestComponent: Add OverloadClass
f33c251 
Copied from microsoft/cppwinrt#1458
dmachaj
dmachaj previously approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@dmachaj dmachaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aspect of the projection is outside my area of expertise but from what I do understand this seems reasonable.

test/test_component/test_overload.cpp Outdated Show resolved Hide resolved
test/test_component/test_component.vcxproj Show resolved Hide resolved
cppwinrt/code_writers.h Outdated Show resolved Hide resolved
@dmachaj dmachaj merged commit cf96df5 into microsoft:master Dec 4, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmachaj dmachaj dmachaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: compiler error when inheriting from DataTemplateSelectorT
2 participants
@sylveon @dmachaj