Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sylveon committed Nov 24, 2024
1 parent ca44055 commit 27d1b6d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
4 changes: 3 additions & 1 deletion cppwinrt/code_writers.h
Original file line number Diff line number Diff line change
Expand Up @@ -2298,7 +2298,9 @@ struct WINRT_IMPL_EMPTY_BASES produce_dispatch_to_overridable<T, D, %>

for (auto&& [interface_name, info] : interfaces)
{
w.write(info.overridable ? " using %T<D>::%;\n" : " using impl::consume_t<D, %>::%;\n",
w.write(info.overridable
? " using %T<D>::%;\n"
: " using impl::consume_t<D, %>::%;\n",
interface_name,
method_name);
}
Expand Down
16 changes: 8 additions & 8 deletions test/test_component/test_overload.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ using namespace test_component;

struct DerivedClass : OverloadClassT<DerivedClass>
{
void Foo()
{
// make sure we can actually call the overloads (no ambiguous call errors)
Overload();
Overload(1);
Overload(1, 2);
Overload(1, 2, 3);
}
void Foo()
{
// make sure we can actually call the overloads (no ambiguous call errors)
Overload();
Overload(1);
Overload(1, 2);
Overload(1, 2, 3);
}
};

0 comments on commit 27d1b6d

Please sign in to comment.