Bug: compiler error when inheriting from DataTemplateSelectorT #1457
Labels
Comments
|
The error from the reproducible test case says "is not a member of a base class of ", but I think this is actually a case of a ambiguous name. Here is the output from compiling some similar code with the clang compiler instead of msvc. |
|
Here's a smaller repro: namespace RuntimeComponent2
{
interface IClass;
interface IClassFactory;
interface IClassOverrides;
interface IClassOverrides2;
[exclusiveto(RuntimeComponent2.Class)]
[uuid(A907D496-46A0-4CD7-8DBE-F9A581DF60B1)]
[version(0x00000001)]
interface IClass : IInspectable
{
}
[exclusiveto(RuntimeComponent2.Class)]
[uuid(511BAAD0-210A-457D-9521-433D2B11B7D2)]
[version(0x00000001)]
interface IClassFactory : IInspectable
{
HRESULT CreateInstance([in] IInspectable* baseInterface, [out] IInspectable** innerInterface, [out][retval] RuntimeComponent2.Class** value);
}
[exclusiveto(RuntimeComponent2.Class)]
[uuid(2D162925-5966-4BFA-8638-4D345689F6CF)]
[version(0x00000001)]
interface IClassOverrides : IInspectable
{
HRESULT Foo(int a);
}
[exclusiveto(RuntimeComponent2.Class)]
[uuid(6C3FB5FC-8E84-4C91-AC15-04A1D885500F)]
[version(0x00000001)]
interface IClassOverrides2 : IInspectable
{
[overload("Foo")] HRESULT Foo2(int a, int b);
}
[composable(RuntimeComponent2.IClassFactory, public,1)]
[marshaling_behavior(agile)]
[threading(both)]
[version(0x00000001)]
runtimeclass Class
{
[default] interface RuntimeComponent2.IClass;
[overridable] interface RuntimeComponent2.IClassOverrides;
[overridable] interface RuntimeComponent2.IClassOverrides2;
}
}
It appears to be a bug in DataTemplateSelector appears to be the only case of this happening |
sylveon
added a commit
to sylveon/cppwinrt
that referenced
this issue
Nov 23, 2024
|
Opened #1458 with a fix. Was relatively trivial thankfully. |
|
Wow, same day service! Thanks for having a look! |
|
Haha. I wanted to make sure it wasn't a regression introduced by a previous PR of mine, which was the last change to code touching overridable members. Once I realized it was a bug in The code was writing an |
|
This issue is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
dmachaj
pushed a commit
that referenced
this issue
Dec 4, 2024
* Fix overloads coming from overridable interfaces Fixes #1457 * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
2.0.240405.15
Summary
There is a compiler error due to code generated by cppwinrt when trying to use
winrt::Windows::UI::Xaml::Controls::DataTemplateSelectorTas a base class.Reproducible example
Grab the project from https://github.com/dlech/BlankApp1, open in Visual Studio and build.
Code that causes the problem is here: https://github.com/dlech/BlankApp1/blob/d2869cb888d4d67534ba76643816a15bfa0274c8/BlankApp1/App.cpp#L16-L18
Expected behavior
cppwrint should generate code that doesn't cause a compile error.
Actual behavior
Build fails with the following error:
Additional comments
I discovered this while working on the PyWinRT bindings. Using any other
TypeTas a base class compiles fine. There seems to be something odd aboutwinrt::Windows::UI::Xaml::Controls::DataTemplateSelectorT::SelectTemplateCorespecially. It is likely the only type where it has two overloads with the same name and different parameters defined in two different interfaces.The text was updated successfully, but these errors were encountered: