Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stevenic/es6 fix #2204

Merged
merged 1 commit into from
May 7, 2020
Merged

Stevenic/es6 fix #2204

merged 1 commit into from
May 7, 2020

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented May 7, 2020

Fixes #2203

Description

Updates declarative and adaptive packages to target ES6.

@Stevenic Stevenic requested a review from stevengum May 7, 2020 20:08
@Stevenic Stevenic requested a review from benbrown as a code owner May 7, 2020 20:08
@coveralls
Copy link

coveralls commented May 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 129184

  • 396 of 438 (90.41%) changed or added relevant lines in 8 files are covered.
  • 96 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.004%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts 1 2 50.0%
libraries/adaptive-expressions/src/expressionFunctions.ts 351 392 89.54%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botbuilder-dialogs-adaptive/src/skills/adaptiveSkillDialog.ts 6 64.38%
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts 7 13.85%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
libraries/botbuilder-dialogs/src/componentDialog.ts 9 80.0%
libraries/adaptive-expressions/src/expressionFunctions.ts 65 89.25%
Totals Coverage Status
Change from base Build 129003: -0.07%
Covered Lines: 12650
Relevant Lines: 15087
💛 - Coveralls

@stevengum stevengum changed the base branch from master to 4.9 May 7, 2020 20:20
@stevengum stevengum merged commit dedb1ad into 4.9 May 7, 2020
@stevengum stevengum deleted the stevenic/es6-fix branch May 7, 2020 20:25
stevengum pushed a commit that referenced this pull request May 7, 2020
@Stevenic @stevengum
Updated packages to target ES6 (#2204)
5e89db9
@stevengum stevengum mentioned this pull request May 7, 2020
Merged
Stevenic added a commit that referenced this pull request May 7, 2020
@stevengum @Stevenic @chrimc62
Cherry-pick ES6 targeting and big-integer addition to master (#2208)
8ad017c 
* Updated packages to target ES6 (#2204)

* Switch adaptive-expressions to es6 (#2205)

* Drop back to es5 and add bigint support.

* Fix test script.

* Fix test script.

* Remove adaptive.

* Remove space.

* Remove changes to package.json.

* update adaptive-expressions target to es5 for initial testing

* Push es5.

Co-authored-by: stevengum <[email protected]>

Co-authored-by: Steven Ickman <[email protected]>
Co-authored-by: Chris McConnell <[email protected]>
@stevengum stevengum mentioned this pull request May 8, 2020
Closed
Stevenic added a commit that referenced this pull request May 8, 2020
@Stevenic @garypretty
@stevengum @boydc2014 @Danieladu @chrimc62 @cosmicshuai
Stevenic/update master (#2214)
001ecb5 
* Add Dialog / PageView telemetry (#2145)

* Update app insights package version

* Add PageView logging

* move TelemetryView helper to botTelemetryClient.ts

* remove telemetry Extensions class, harden helper method, add tests

Co-authored-by: Steven Gum <[email protected]>

* move botbuilder-lg and adaptive-expressions out of preview (#2190)

* move botbuilder-lg and adaptive-expressions out of preview

* correct set-version script in preview packages

* restore preview packages to using Version instead of PreviewPackageVersion

* Fixed issues with AdaptiveSkillDialog (#2196)

and added unit tests

* [Cherry-pick] timex and formatX functions (#2200)

* [PORT] [Expression] Add more timex builtin functions (#2187)

* add more timex function

* fix typo

* fix typo

* Add formatNumber, parseEpoch and parseTicks. (#2198)

* Add formatNumber, parseEpoch and parseTicks.

* Switch to ESNext like other packages.
Switch ticks to bigInt.
Add tests.

Co-authored-by: Shuai Wang <[email protected]>

Co-authored-by: Hongyang Du (hond) <[email protected]>
Co-authored-by: Chris McConnell <[email protected]>
Co-authored-by: Shuai Wang <[email protected]>

* Updated packages to target ES6 (#2204)

* Switch adaptive-expressions to es6 (#2205)

* Drop back to es5 and add bigint support.

* Fix test script.

* Fix test script.

* Remove adaptive.

* Remove space.

* Remove changes to package.json.

* update adaptive-expressions target to es5 for initial testing

* Push es5.

Co-authored-by: stevengum <[email protected]>

* Renamed AdaptiveSkillDialog to BeginSkillDialog (#2212)

* Renamed BeginSkill action again (#2215)

* Renamed BeginSkill action again

* update component registration

Co-authored-by: Gary Pretty <[email protected]>
Co-authored-by: Steven Gum <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Hongyang Du (hond) <[email protected]>
Co-authored-by: Chris McConnell <[email protected]>
Co-authored-by: Shuai Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive & Declarative libraries target ESNext
3 participants
@Stevenic @coveralls @stevengum