Renamed BeginSkill action again #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
previously requested changes
May 8, 2020
|
Related to feedback on microsoft/botbuilder-dotnet#3891 |
tomlm
reviewed
May 8, 2020
| @@ -35,7 +35,7 @@ export class AdaptiveDialogComponentRegistration implements ComponentRegistratio | |||
| this.registerBuilder('Microsoft.AdaptiveDialog', new AdaptiveTypeBuilder(AdaptiveDialog, this._resourceExplorer, { | |||
| 'generator': new LanguageGeneratorConverter() | |||
| })); | |||
| this.registerBuilder('Microsoft.BeginSkillDialog', new AdaptiveTypeBuilder(BeginSkillDialog, this._resourceExplorer, { | |||
| this.registerBuilder('Microsoft.BeginSkillDialog', new AdaptiveTypeBuilder(BeginSkill, this._resourceExplorer, { | |||
There was a problem hiding this comment.
this.registerBuilder('Microsoft.BeginSkillDialog', new [](start = 8, length = 55)
Microsoft.BeginSkill #Closed
stevengum
approved these changes
May 8, 2020
Stevenic
added a commit
that referenced
this pull request
May 8, 2020
* Add Dialog / PageView telemetry (#2145) * Update app insights package version * Add PageView logging * move TelemetryView helper to botTelemetryClient.ts * remove telemetry Extensions class, harden helper method, add tests Co-authored-by: Steven Gum <[email protected]> * move botbuilder-lg and adaptive-expressions out of preview (#2190) * move botbuilder-lg and adaptive-expressions out of preview * correct set-version script in preview packages * restore preview packages to using Version instead of PreviewPackageVersion * Fixed issues with AdaptiveSkillDialog (#2196) and added unit tests * [Cherry-pick] timex and formatX functions (#2200) * [PORT] [Expression] Add more timex builtin functions (#2187) * add more timex function * fix typo * fix typo * Add formatNumber, parseEpoch and parseTicks. (#2198) * Add formatNumber, parseEpoch and parseTicks. * Switch to ESNext like other packages. Switch ticks to bigInt. Add tests. Co-authored-by: Shuai Wang <[email protected]> Co-authored-by: Hongyang Du (hond) <[email protected]> Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Shuai Wang <[email protected]> * Updated packages to target ES6 (#2204) * Switch adaptive-expressions to es6 (#2205) * Drop back to es5 and add bigint support. * Fix test script. * Fix test script. * Remove adaptive. * Remove space. * Remove changes to package.json. * update adaptive-expressions target to es5 for initial testing * Push es5. Co-authored-by: stevengum <[email protected]> * Renamed AdaptiveSkillDialog to BeginSkillDialog (#2212) * Renamed BeginSkill action again (#2215) * Renamed BeginSkill action again * update component registration Co-authored-by: Gary Pretty <[email protected]> Co-authored-by: Steven Gum <[email protected]> Co-authored-by: Dong Lei <[email protected]> Co-authored-by: Hongyang Du (hond) <[email protected]> Co-authored-by: Chris McConnell <[email protected]> Co-authored-by: Shuai Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed BeginSkillDialog => BeginSkill