Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick ES6 targeting and big-integer addition to master #2208

Merged
merged 2 commits into from
May 7, 2020
Merged

Cherry-pick ES6 targeting and big-integer addition to master #2208

merged 2 commits into from
May 7, 2020

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented May 7, 2020 •
edited
Loading

Fixes #2207

Specific Changes

Stevenic and others added 2 commits May 7, 2020 15:31
@Stevenic @stevengum
Updated packages to target ES6 (#2204)
5e89db9
@chrimc62 @stevengum
Switch adaptive-expressions to es6 (#2205)
e3ee826 
* Drop back to es5 and add bigint support.

* Fix test script.

* Fix test script.

* Remove adaptive.

* Remove space.

* Remove changes to package.json.

* update adaptive-expressions target to es5 for initial testing

* Push es5.

Co-authored-by: stevengum <[email protected]>
@stevengum stevengum requested a review from cleemullins May 7, 2020 22:35
@coveralls
Copy link

coveralls commented May 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 129244

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 80.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/expressionFunctions.ts 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 129003: -0.08%
Covered Lines: 12652
Relevant Lines: 15090
💛 - Coveralls

@Stevenic Stevenic merged commit 8ad017c into master May 7, 2020
@Stevenic Stevenic deleted the stgum/cherry-picks branch May 7, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cherry-pick #2204 and #2205 to master
4 participants
@stevengum @coveralls @Stevenic @chrimc62