Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage for botbuilder library #2432

Closed
axelsrz opened this issue Jun 26, 2020 · 3 comments
Closed

Increase coverage for botbuilder library #2432

axelsrz opened this issue Jun 26, 2020 · 3 comments
Assignees
@JuanAr @mrivera-ms
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P0 Must Fix. Release-blocker R10 Release 10 - August 17th, 2020
Milestone
R10

Comments

@axelsrz
Copy link
Member

axelsrz commented Jun 26, 2020

Increase unit test coverage of botbuilder package to 80%
@axelsrz axelsrz added P0 Must Fix. Release-blocker R10 Release 10 - August 17th, 2020 Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. labels Jun 26, 2020
@cleemullins cleemullins assigned mrivera-ms and unassigned stevengum Jun 30, 2020
@cleemullins
Copy link
Contributor

Consider for Southworks to complete.

@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
This was referenced Jul 6, 2020
Merged
Merged
@denscollo
Copy link
Contributor

denscollo commented Jul 6, 2020 •
edited by ceciliaavila
Loading

We divided the issue into the existing classes in which we'll increase the CC, and create a PR for each one.

This is the list and its status:

This was referenced Jul 7, 2020
Merged
Merged
Merged
Merged
This was referenced Jul 15, 2020
Merged
Merged
@axelsrz
Copy link
Member Author

axelsrz commented Aug 4, 2020 •
edited
Loading

Closing due to completion.

@axelsrz axelsrz closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

@mrivera-ms mrivera-ms

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P0 Must Fix. Release-blocker R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
R10
Development

No branches or pull requests
7 participants
@JuanAr @cleemullins @axelsrz @stevengum @denscollo @munozemilio @mrivera-ms