Increase code coverage in botbuilder library - BotFrameworkAdapter class #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deleteConversationMembers - getConversations - constructor
ceciliaavila
requested review from
carlosscastro,
johnataylor and
Stevenic
as code owners
stevengum
approved these changes
Jul 14, 2020
|
Please rebase against master. (sorry, it looks like you've done this a couple times already... let me know when this is rebased and we will merge it before something else goes into master) |
|
@EricDahlvang we just rebased it against master, so it's ready! Thanks! |
|
@denscollo merged, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2432
Description
This PR adds unit tests for the BotFrameworkAdapter class increasing the code coverage from 77.43% to 91.59%.
Specific Changes
Testing
The next images show some of the new tests passing.
