Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage in botbuilder library - TeamsActivityHandler class #2495

Merged

Conversation

denscollo
Copy link
Contributor

Addresses #2432

Description

This PR adds unit tests for the TeamsActivityHandler class increasing the code coverage from 73.68% to 100%.

Specific Changes

Testing

The following images show the new tests passing.
imagen
imagen

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below.

@denscollo denscollo requested a review from a team as a code owner July 14, 2020 18:03
@denscollo
Copy link
Contributor Author

denscollo commented Jul 15, 2020

@stevengum Thanks for the feedback, we just pushed the changes. #Resolved

@mrivera-ms mrivera-ms requested a review from EricDahlvang July 16, 2020 00:28
Copy link
Contributor

@mrivera-ms mrivera-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrivera-ms mrivera-ms merged commit 60760be into microsoft:master Jul 16, 2020
@ceciliaavila ceciliaavila deleted the southworks/add/TeamsActivityHandler-tests branch July 16, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants