Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage in botbuilder library - TeamsInfo class #2531

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Increase code coverage in botbuilder library - TeamsInfo class #2531

merged 2 commits into from
Jul 14, 2020

Conversation

denscollo
Copy link
Contributor

Addresses #2432

Description

This PR adds unit tests for the TeamsInfo class increasing the code coverage from 74.42% to 86.05%.

Specific Changes

  • Updated teamsInfo.test.js file with tests for the following methods:

    • getTeamMember
    • getMemberInternal
    • getPagedMembersInternal
    • getTeamId

  • Updated TeamsInfo class to fix an error message.

Testing

The next images show some of the new tests passing.
image

@denscollo denscollo requested a review from a team as a code owner July 14, 2020 17:55
@denscollo denscollo mentioned this pull request Jul 14, 2020
Closed
@stevengum stevengum merged commit 5f38915 into microsoft:master Jul 14, 2020
@ceciliaavila ceciliaavila deleted the southworks/add/teamsInfo-tests branch August 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denscollo @stevengum @ceciliaavila