-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TelemetryClient to enable tracking of dialog ('page') views #3440
Conversation
…atic page view logging on dialog start for component / waterfall dialogs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
…logging middleware / dialog classes
Agreed with @christopheranderson that, providing we go ahead with this approach, we will not obselete the existing telemetry bits until R9 - this will allow us to run the two side by side until all of our messaging etc is up to date and also to provide us with a chance to ensure that the new bits meet the demands of adaptive too. This also presents the possibility of us deferring the JS and other repo updates to R9 as well if we don't get through them all next week. |
…s until future release.
Update: Due to the fact that if we pursue a non-breaking change then 100% of people who have telemetry enabled within their existing bots will need to make changes to migrate to an updated configuration, coupled with the fact that it is very likely that the number of people to extend the IBotTelemetryClient interface within their own solution is incredibly small - the decision has been taken to extend the interface. cc @cleemullins / @scheyal |
Implemented additional interface / extension method to avoid breaking change as discussed with @johnataylor |
Addresses #3441
Update TelemetryClient to enable tracking of page views and add automatic page view logging on dialog start for component / waterfall dialogs.
This PR now adds a new abstract class, LogTelemetryClient, as well as an implementation of it within the ApplicationInsights library, AppInsightsTelemetryClient. All current consumers of the existing BotTelemetryClient have been updated to use the new client, but leaving the existing functionality in place (marked as obselete) for backwards compatibility.