Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Update TelemetryClient to enable tracking of dialog ('page') views #1792

Closed
garypretty opened this issue Feb 25, 2020 · 4 comments · Fixed by #2145
Closed

[PORT] Update TelemetryClient to enable tracking of dialog ('page') views #1792

garypretty opened this issue Feb 25, 2020 · 4 comments · Fixed by #2145
Assignees
@garypretty
Labels
P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Milestone
R10

Comments

@garypretty
Copy link
Contributor

As per C# issue microsoft/botbuilder-dotnet#3441

C# PR -> microsoft/botbuilder-dotnet#3440

This is to support the ability to track user flows within application insights and understand how users move between dialogs within a conversation using the built in user flows / funnels pages within App Insights portal.

[enhancement]
@garypretty garypretty added the R8 Release 8 - March 16th, 2020 label Feb 25, 2020
@garypretty garypretty self-assigned this Feb 25, 2020
@johnataylor johnataylor added the P1 Painful if we don't fix, won't block releasing label Mar 2, 2020
@garypretty garypretty added R9 Release 9 - May 15th, 2020 and removed R8 Release 8 - March 16th, 2020 labels Mar 5, 2020
@garypretty
Copy link
Contributor Author

@scheyal @christopheranderson Pushing this out to R9 - the app insights SDK we use in JS does not currently surface TrackPageView - we have left it in C# but will not change any docs to reflect this addition until we have parity. Need to reach out to the App Insights folks and either have them implement or see if they will accept a PR.

Leaving the feature within C# though as it is completely additive and I have added the PageView feature to adaptive, so this can be taken advantage of in the R8 window.

cc @cleemullins

@garypretty garypretty mentioned this issue Mar 5, 2020
Closed
@garypretty
Copy link
Contributor Author

Currently blocked due to a change being required in App Insights SDK. Unlikely to make R9, so pushing to R10.

@garypretty garypretty added R10 Release 10 - August 17th, 2020 and removed R9 Release 9 - May 15th, 2020 labels Apr 8, 2020
@garypretty
Copy link
Contributor Author

PR raised on the App Insights node SDK - this issue is blocked until that PR is merged and a new release is available. microsoft/ApplicationInsights-node.js#616

@garypretty garypretty added the blocked Current progress is blocked on something else. label Apr 20, 2020
@garypretty
Copy link
Contributor Author

PR accepted and merged in the App Insights Node SDK. Now awaiting release to npm.

@garypretty garypretty mentioned this issue Apr 30, 2020
Merged
@garypretty garypretty removed the blocked Current progress is blocked on something else. label May 1, 2020
@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypretty garypretty

Labels
P1 Painful if we don't fix, won't block releasing R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
R10
Development

Successfully merging a pull request may close this issue.

Add Dialog / PageView telemetry microsoft/botbuilder-js
3 participants
@johnataylor @garypretty @munozemilio