Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Update TelemetryClient to enable tracking of dialog ('page') views #1844

Closed
tomlm opened this issue Mar 4, 2020 · 1 comment
Closed

[PORT] Update TelemetryClient to enable tracking of dialog ('page') views #1844

tomlm opened this issue Mar 4, 2020 · 1 comment

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 4, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3440

Addresses #3441

Update TelemetryClient to enable tracking of page views and add automatic page view logging on dialog start for component / waterfall dialogs.

This PR now adds a new abstract class, LogTelemetryClient, as well as an implementation of it within the ApplicationInsights library, AppInsightsTelemetryClient. All current consumers of the existing BotTelemetryClient have been updated to use the new client, but leaving the existing functionality in place (marked as obselete) for backwards compatibility.

Changed projects

  • Microsoft.Bot.Builder.ApplicationInsights
  • Microsoft.Bot.Builder.Dialogs
  • Microsoft.Bot.Builder
  • integration
  • Microsoft.Bot.Builder.ApplicationInsights.Tests
  • Microsoft.Bot.Builder.Dialogs.Tests
@garypretty
Copy link
Contributor

Closing - duplicate of #1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garypretty @tomlm