Add HTML Media types #802
Add HTML Media types #802
Conversation
Yes, several MS- and WebKit-specific types have been removed since we started to use Web IDL. Some of them are listed in removedTypes.json but generally are just overridden without manual list.
AFAICT the removed types here are:
I think use of DRM should be rare enough. |
There was a problem hiding this comment.
Had a look through this PR, I get that it removes a bunch of the old IE-y bits in favor of an IDL which is a big 👍 but it's replacing it with the API which is still flagged
The Media Playback Quality change we can insta-merge, but until the "HTML - Media" is un-flagged in either FF/Chromium we shouldn't be adding it to the main libs
| { | ||
| "url": "https://html.spec.whatwg.org/multipage/media.html", | ||
| "title": "HTML - Media" | ||
| }, |
There was a problem hiding this comment.
This is the controversial one: It's only supported in Safari and old edge today (without flags ) according to caniuse:
There was a problem hiding this comment.
Ah, didn't know that, nice find! But those types are already in lib.d.ts so removing them might affect existing users. Should I remove them anyway?
There was a problem hiding this comment.
We think of it as the status quo is wrong, yep, but adding the new spec would make people expect something exists in the runtime which doesn't (without turning on a flag for 90% of the web).
If it gets removed from the PR is it still feasible for the media playback to come in? Then we keep the dodgy existing behavior until the runtime features available for everyone
There was a problem hiding this comment.
The spec itself also covers an essential part of HTML - HTMLAudio/Video/TrackElement, so I think the spec should still be added, while we can drop specific types mentioned here.
If it gets removed from the PR is it still feasible for the media playback to come in?
It shouldn't be affected, as it only adds a function.
There was a problem hiding this comment.
Yep, I agree - let's do that 👍
| { | ||
| "url": "https://w3c.github.io/media-playback-quality/", | ||
| "title": "Media Playback Quality" | ||
| }, |
There was a problem hiding this comment.
This one seems totally fine, it's an editor's draft - yep, but every browser seems to be supporting it
|
Had to also remove |
| @@ -241,6 +249,9 @@ | |||
| }, | |||
| "interfaces": { | |||
| "interface": { | |||
| "AudioTrack": { | |||
| "exposed": "" | |||
There was a problem hiding this comment.
This is a way to properly exclude certain types from unions.
AudioTrackList isn't standard, and is removed from the DOM in TS 3.9: microsoft/TypeScript-DOM-lib-generator#802 This PR removes it from dom-mediacapture-record
AudioTrackList isn't standard, and is removed from the DOM in TS 3.9: microsoft/TypeScript-DOM-lib-generator#802 This PR removes it from dom-mediacapture-record
AudioTrack isn't standard (only supported in IE and Safari), and is removed from the DOM lib in TS 3.9: microsoft/TypeScript-DOM-lib-generator#802 This PR puts a copy of the type called VideojsAudioTrack in instead. That should be compatible with the DOM version for older Typescripts, since it's copied directly from the old source.
AudioTrack isn't standard (only supported in IE and Safari), and is removed from the DOM lib in TS 3.9: microsoft/TypeScript-DOM-lib-generator#802 This PR puts a copy of the type called VideojsAudioTrack in instead. That should be compatible with the DOM version for older Typescripts, since it's copied directly from the old source.
| } | ||
|
|
||
| /** Used to represent a list of the audio tracks contained within a given HTML media element, with each track represented by a separate AudioTrack object in the list. */ | ||
| interface AudioTrackList extends EventTarget { |
There was a problem hiding this comment.
Why were these removed? They're part of the DOM standard: https://html.spec.whatwg.org/multipage/media.html#audiotracklist
There was a problem hiding this comment.
True, but unfortunately nobody has a stable implementation per MDN and TSJS-lib-generator generally should only include stable ones.
No description provided.