Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceBuffer.audioTracks/videoTracks/textTracks are not actually supported #5781

Closed
saschanaz opened this issue Mar 4, 2020 · 6 comments · Fixed by #6655
Closed

SourceBuffer.audioTracks/videoTracks/textTracks are not actually supported #5781

saschanaz opened this issue Mar 4, 2020 · 6 comments · Fixed by #6655
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Mar 4, 2020 •
edited
Loading

BCD says it's supported for all browsers for a long time but actually both Firefox and Chrome does not have them.
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 4, 2020
@saschanaz saschanaz mentioned this issue Mar 4, 2020
Merged
@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz mentioned this issue Mar 15, 2020
Merged
@sideshowbarker
Copy link
Collaborator

I’m closing this issue as being fixed by #5828. I’m aware of the comment there which says:

This only removes unsupported features without fixing version numbers for supported ones

…but “fixing version numbers for supported ones” can be handled by another PR or issue.

@saschanaz saschanaz mentioned this issue May 6, 2020
Closed
@foolip
Copy link
Collaborator

foolip commented Sep 7, 2020

#5828 only partially fixed this, the support data for audioTracks/videoTracks is still wrong for at least Chrome.

@foolip foolip reopened this Sep 7, 2020
@foolip foolip mentioned this issue Sep 7, 2020
Closed
@saschanaz
Copy link
Contributor Author

saschanaz commented Sep 7, 2020 •
edited
Loading

Ah, I opened #6102 for that. Oops, it seems it's again about unsupported ones. Okay then.

@sideshowbarker
Copy link
Collaborator

It seems like we could really use some guidance and insight from @jpmedley on this one.

foolip added a commit to foolip/browser-compat-data that referenced this issue Sep 8, 2020
@foolip
Sort out AudioTrack and VideoTrack support in Chromium
924db00 
Most of the IDL was added in June 2014 behind a flag:
https://chromium.googlesource.com/chromium/src/+/cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa

That was M37 based on the date: https://www.chromium.org/developers/calendar

Note that https://storage.googleapis.com/chromium-find-releases-static/cb9.html#cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa
is wrong because this change happened before Blink was merged into
the Chromium tree.

The AudioVideoTracks has never been enabled by default.

The audioTrack and videoTrack attributes on SourceBuffer were added
later, in March 2016, behind the same flag:
https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

That was M51: https://storage.googleapis.com/chromium-find-releases-static/923.html#92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

The data was mirrored for Edge and Opera. Samsung Internet and WebView
don't use flags.

Fixes mdn#5781.
@foolip foolip mentioned this issue Sep 8, 2020
Merged
foolip added a commit to foolip/browser-compat-data that referenced this issue Sep 8, 2020
@foolip
Sort out AudioTrack and VideoTrack support in Chromium
d4d3c20 
Most of the IDL was added in June 2014 behind a flag:
https://chromium.googlesource.com/chromium/src/+/cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa

That was M37 based on the date: https://www.chromium.org/developers/calendar

Note that https://storage.googleapis.com/chromium-find-releases-static/cb9.html#cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa
claiming this was added in M45 is wrong because this change happened
before Blink was merged into the Chromium tree.

The AudioVideoTracks has never been enabled by default.

The audioTrack and videoTrack attributes on SourceBuffer were added
later, in April/March 2016, behind the same flag:
https://chromium.googlesource.com/chromium/src/+/1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

These changes were in M51:
https://storage.googleapis.com/chromium-find-releases-static/1b3.html#1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://storage.googleapis.com/chromium-find-releases-static/923.html#92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

The data was mirrored for Edge and Opera. Samsung Internet and WebView
don't use flags.

Fixes mdn#5781.
@foolip
Copy link
Collaborator

foolip commented Sep 8, 2020

I've looked up where these things were implemented and sent #6655 to sort it out.

Rant: I kinda wish we didn't have flags in BCD, it's a lot of work to sort out when it's wrong.

jpmedley pushed a commit that referenced this issue Sep 10, 2020
@foolip
Sort out AudioTrack and VideoTrack support in Chromium (#6655)
afd6e3c 
Most of the IDL was added in June 2014 behind a flag:
https://chromium.googlesource.com/chromium/src/+/cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa

That was M37 based on the date: https://www.chromium.org/developers/calendar

Note that https://storage.googleapis.com/chromium-find-releases-static/cb9.html#cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa
claiming this was added in M45 is wrong because this change happened
before Blink was merged into the Chromium tree.

The AudioVideoTracks has never been enabled by default.

The audioTrack and videoTrack attributes on SourceBuffer were added
later, in April/March 2016, behind the same flag:
https://chromium.googlesource.com/chromium/src/+/1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

These changes were in M51:
https://storage.googleapis.com/chromium-find-releases-static/1b3.html#1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://storage.googleapis.com/chromium-find-releases-static/923.html#92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1

The data was mirrored for Edge and Opera. Samsung Internet and WebView
don't use flags.

Fixes #5781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort out AudioTrack and VideoTrack support in Chromium foolip/browser-compat-data
4 participants
@sideshowbarker @foolip @saschanaz @queengooborg