Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SourceBuffer.prototype.*Tracks support #5828

Merged
merged 1 commit into from
Mar 26, 2020
Merged

No SourceBuffer.prototype.*Tracks support #5828

merged 1 commit into from
Mar 26, 2020

Conversation

saschanaz
Copy link
Contributor

Related to #5781

This only removes unsupported features without fixing version numbers for supported ones as I'm not sure of them:

  • Firefox never supported all *Tracks
  • Chrome never supported textTracks
  • IE11 does not support textTracks

@ghost ghost added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 15, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Mar 20, 2020

@jpmedley Would you be willing to double check the Chrome part of this (it might help to read #5781)? I thought it looked right, but I was 100% sure

@ddbeck ddbeck requested a review from jpmedley March 20, 2020 20:58
@jpmedley
Copy link
Contributor

My research says this is supported on Chrome and has been for years. @saschanaz can you tell me why you think it doesn't work?

@saschanaz
Copy link
Contributor Author

My research says this is supported on Chrome and has been for years. @saschanaz can you tell me why you think it doesn't work?

Hi @jpmedley, that's HTMLMediaElement#textTracks but what I'm talking about is SourceBuffer#textTracks.

@saschanaz
Copy link
Contributor Author

saschanaz commented Mar 25, 2020 •
edited
Loading

Also from #5781 (comment):

  • Chrome added flagged support for audioTracks/videoTracks in March 2016, but no textTracks

Here is the diff: https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1%5E%21/#F19

@jpmedley
Copy link
Contributor

Chrome stuff looks right to me.

Elchi3
Elchi3 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone! 👍

@Elchi3 Elchi3 merged commit 1233fce into mdn:master Mar 26, 2020
@Elchi3 Elchi3 removed the request for review from jpmedley March 26, 2020 16:46
@saschanaz saschanaz deleted the tracks branch March 26, 2020 16:47
@sideshowbarker sideshowbarker mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschanaz @ddbeck @jpmedley @Elchi3