Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videogular2 build does not work anymore #893

Closed
Dudedex opened this issue May 13, 2020 · 6 comments · Fixed by #894
Closed

Videogular2 build does not work anymore #893

Dudedex opened this issue May 13, 2020 · 6 comments · Fixed by #894
Assignees

Comments

@Dudedex
Copy link

Dudedex commented May 13, 2020

Description

Can not build angular project that uses videogular2 (since today May 13th 2020) (Version 7.0.1)

Expected Behavior

Build should work as before

Actual Behavior

When building with angular cli 8.3.26 the following message shows up

ERROR in node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(17,27): error TS2304: Cannot find name 'AudioTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(139,27): error TS2304: Cannot find name 'VideoTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(5,27): error TS2304: Cannot find name 'AudioTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(42,18): error TS2304: Cannot find name 'VideoTrackList'.

Steps to Reproduce

Remove node_modules => build angular project => error occurs

@IxquitilisSaid IxquitilisSaid self-assigned this May 13, 2020
IxquitilisSaid added a commit that referenced this issue May 13, 2020
… Fix type cast for failing test

TS version bump required for AudioAPI type defs on compile

#893
@Elecash
Copy link
Member

Elecash commented May 13, 2020

🎉 This issue has been resolved in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Dudedex
Copy link
Author

Dudedex commented May 14, 2020

It also does not work with 7.0.2

still the same error when building with 7.0.2

ERROR in node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(17,27): error TS2304: Cannot find name 'AudioTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/i-media-element.d.ts(139,27): error TS2304: Cannot find name 'VideoTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(5,27): error TS2304: Cannot find name 'AudioTrackList'.
node_modules/videogular2/compiled/src/core/vg-media/vg-media-element.d.ts(42,18): error TS2304: Cannot find name 'VideoTrackList'.

@Elecash
Copy link
Member

Elecash commented May 14, 2020

Did you tried downloading the project from scratch and doing npm install?

The project works for me.

@Dudedex
Copy link
Author

Dudedex commented May 14, 2020

removing the node_modules

and installing it again via npm install => also checked the version in the node_modules folder to be sure that it is the 7.0.2 version

@Elecash
Copy link
Member

Elecash commented May 14, 2020

Try removing also any "metadata" file and package-lock.json, it might have some old dependencies there.

@IxquitilisSaid
Copy link
Member

so, it's a rabbit hole but the gist is (the links I'm about to send are in reverse chronological order for a reason):

TL;DR: Don't use TS 3.9.2 for now. Anything below is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants