Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Run] Revert ClearType regression #10568

Merged
merged 1 commit into from
Apr 5, 2021
Merged

[Run] Revert ClearType regression #10568

merged 1 commit into from
Apr 5, 2021

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Apr 3, 2021 •
edited
Loading

Summary of the Pull Request

Removed manual ClearType setting since it causes on higher resolution screens (as discussed with @crutkas here: #6462). It now renders smoother.

Before:
RunCT

After:
RunwithoutCT

Quality Checklist

  • Linked issue: [Run] ClearType regression #6462
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@niels9001 niels9001 requested a review from crutkas April 3, 2021 18:44
@htcfreek htcfreek added Area-User Interface things that regard UX for PowerToys Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Apr 4, 2021
@niels9001 niels9001 changed the title [Run] Revert cleartype regression [Run] Revert ClearType regression Apr 5, 2021
@enricogior
Copy link
Contributor

enricogior commented Apr 5, 2021 •
edited
Loading

We can merge this but there is a larger issue with the way DPI awareness is handled.

@niels9001
Copy link
Contributor Author

We can merge this but there is a larger issue with the way DPI awareness is handled.

Would moving to WinUI 3.0 resolve that?

@enricogior enricogior mentioned this pull request Apr 5, 2021
Closed
@enricogior
Copy link
Contributor

@niels9001
I don't know, we need to investigate it #10592

@enricogior enricogior merged commit ed21dba into master Apr 5, 2021
@enricogior enricogior deleted the users/niels9001/run-cleartyperegression branch April 5, 2021 14:36
@crutkas crutkas mentioned this pull request Apr 12, 2021
Closed
@onesounds onesounds mentioned this pull request Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricogior enricogior enricogior approved these changes

@crutkas crutkas Awaiting requested review from crutkas

Assignees
No one assigned
Labels
Area-User Interface things that regard UX for PowerToys Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niels9001 @enricogior @htcfreek