Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] investigate DPI Awareness for font rendering #10592

Closed
enricogior opened this issue Apr 5, 2021 · 13 comments
Closed

[Run] investigate DPI Awareness for font rendering #10592

enricogior opened this issue Apr 5, 2021 · 13 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Cost-Medium Medium work item - 1-3 Days worth of work. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-PowerToys Run Improved app launch PT Run (Win+R) Window Status-No recent activity no activity in the past 5 days when follow up's are needed

Comments

@enricogior
Copy link
Contributor

On a 4K monitor at 200%

0.35:
image

PR #10568:
image

It's slightly better but far from ideal.

@enricogior enricogior added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Planning-Consideration Consideration for 2021 stability release labels Apr 5, 2021
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 5, 2021
@enricogior enricogior removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 5, 2021
@enricogior
Copy link
Contributor Author

enricogior commented Apr 5, 2021

In the app manifest, setting the dpiAwareness like this:

  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2</dpiAwareness>
    </windowsSettings>
  </application>

result:
image

but it's not placed in the center of the screen (shouldn't be too hard too fix the position).

@enricogior enricogior added the Area-User Interface things that regard UX for PowerToys label Apr 5, 2021
@crutkas
Copy link
Member

crutkas commented Apr 5, 2021

oooooooooooooooo

@crutkas
Copy link
Member

crutkas commented Apr 5, 2021

this seems like an easy fix to add that, right?

@enricogior
Copy link
Contributor Author

@crutkas

this seems like an easy fix to add that, right?

It depends, in FZ Editor we couldn't use it because of a framework bug that prevented us from fine controlling the windows position on non-primary monitors in some multi-monitor configuration where different DPI scaling factors are used.
For PT Run, given the less complex UI, the bug might not show up, but we need to test it.

@crutkas
Copy link
Member

crutkas commented Apr 6, 2021

We should document that quirk but yes, i think this is a good item. put this in 39/41?

@enricogior
Copy link
Contributor Author

@crutkas
we have a test app that shows the .Net DPI bug https://github.com/microsoft/PowerToys/tree/master/tools/FancyZonesEditor_DPI_test we need to add a readme to provide context.

@mykhailopylyp
Copy link
Contributor

@enricogior @crutkas
A WPF application is not able to automatically handle dpi scaling without additional developer work. Take a look at High DPI Desktop Application Development on Windows. Positioning of PT Run is already dpi aware but height and width are not.

I'm wondering if it makes sense to postpone this item until we migrate to winui. Any thoughts?

@crutkas
Copy link
Member

crutkas commented Jun 2, 2021

how easy is the fix?

@mykhailopylyp
Copy link
Contributor

I think it is a medium-cost item. Also, probably we are going to have the same issues as in #5616. I don't think the same workaround will work for this issue.

@rinsuki
Copy link

rinsuki commented Aug 12, 2021

Duplicate of #8949?

@Aaron-Junker Aaron-Junker added the Cost-Medium Medium work item - 1-3 Days worth of work. label Dec 24, 2021
@Jay-o-Way
Copy link
Collaborator

Is this still an issue with the latest version? /needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Jul 13, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Cost-Medium Medium work item - 1-3 Days worth of work. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-PowerToys Run Improved app launch PT Run (Win+R) Window Status-No recent activity no activity in the past 5 days when follow up's are needed
Projects
None yet
Development

No branches or pull requests

6 participants