-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity] Fix Car API #2937
[Unity] Fix Car API #2937
Conversation
f7ab89c
to
6a5366c
Compare
@madratman @saihv @jonyMarino If possible, could you have a look at why Travis is not triggering and the Azure Pipelines status aren't getting updated? Seems to be happening for all PRs in the last 2-3 days Edit: Travis does get triggered, but not appearing in the CI checks - https://travis-ci.org/github/microsoft/AirSim/pull_requests |
6a5366c
to
cf2e994
Compare
cf2e994
to
456e71c
Compare
Thank you, this PR solved my problem! Why is it not merged into master yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor style changes. Tested with PythonClient\car\hello_car.py, PythonClient\car\drive_straight.py, and PythonClient\car\car_monitor.py, and the PR appears to work as intested
Unity/AirLibWrapper/AirsimWrapper/Source/Vehicles/Car/CarPawnSimApi.cpp
Outdated
Show resolved
Hide resolved
Unity/AirLibWrapper/AirsimWrapper/Source/Vehicles/Car/CarPawnSimApi.cpp
Outdated
Show resolved
Hide resolved
Unity/AirLibWrapper/AirsimWrapper/Source/Vehicles/Car/SimModeCar.cpp
Outdated
Show resolved
Hide resolved
Set API enabled so that it uses API controls rather than keyboard
456e71c
to
99089bf
Compare
Thanks for the contribution @rajat2004! |
Set API enabled so that it uses API controls rather than keyboard
Plus fix some warnings
Will be easier to review commit wise
Closes #2679, closes #2636, closes #2631
Some more cleanup needs to be done,
keyboard_controls_
is actually incorrect and doesn't contain the keypresses, that is actually been done here. It can be seen that the external controls are applied only whenisApiEnabled
istrue
, which is being added in this PR.CarPawn
is supposed to provide thekeyboard_controls
but is just a placeholder, and doesn't do anything, so I think that can be removedTODO:
CarPawnSimApi
can fetch the keyboard controls fromCar.cs
, without this, thegetCarControls
API won't work to fetch the keyboard values.airsim_unity_car_api.mp4
These changes will diverge Unity implementation from Unreal one, but shouldn't be much of a problem