-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python API example files #2683
Conversation
# currently reset() doesn't work in CV mode. Below is the workaround | ||
client.simSetPose(airsim.Pose(airsim.Vector3r(0, 0, 0), airsim.to_quaternion(0, 0, 0)), True) No newline at end of file | ||
client.simSetVehiclePose(airsim.Pose(airsim.Vector3r(0, 0, 0), airsim.to_quaternion(0, 0, 0)), True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually client.reset()
does work in CV mode
My guess would be we can change the buffer type of Unity from RGBA to RGB by not copying over the alpha channel? |
@madratman I think this is the one we need - https://github.com/microsoft/AirSim/blob/master/Unity/UnityDemo/Assets/AirSimAssets/Scripts/Utilities/DataCaptureScript.cs#L153 |
No, I think it would be for the better as it establishes consistency in num of channels in UE and Unity, |
Maintain consistency with Unreal
Made the Unity change, and reversed the channel change in the script.
Forgot that I had mentioned the 1st problem in the PR description itself... |
Merging this.. let's track the remaining issues in new PRs |
#2937 fixes the Unity Car API problem, still needs a bit more work though |
Changes -
Just some things noticed when trying to figure out why Unity Car APIs aren't working which has been reported on multiple issues. I'm not seeing anything wrong or different from the Unreal implementation right now. Ping @madratman @saihv
Unity returns RGBA while Unreal does RGB (Not after this PR)