Add support for Distance Sensor in ArduPilot #2920
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -
Win Blocks binary - https://drive.google.com/file/d/1eLaC58nnh0ms9BhHqvVMnXo9o_xiH3pr/view?usp=sharing
TODO:
Corresponding AP PR - ArduPilot/ardupilot#15007
Follow-up after #2807
Code duplication, any ideas on how this can be reduced?
Second-last commit fixes a style inconsistency, camel case is not used for variables there, also no idea why I used
shared_ptr
, maybe a remanent of earlier copy-paste from PX4 backend.Last one updates C++ standard used in Unity to C++14, required for
make_unique
(see https://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique), otherwise this happensHowever, AirLib is built with C++17 standard in UE, which can cause problems later on. Should it be updated further to 17? (Tested it to be working locally)