Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing DistanceSensorData type and wrong param name in getDistanceSensorData() #2403

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix missing DistanceSensorData type and wrong param name in getDistanceSensorData() #2403

merged 1 commit into from
Mar 23, 2020

Conversation

sorensenmarius
Copy link
Contributor

  • Wrong variable name in getDistanceSensor()
  • Missing type for DistanceSensorData

Fixes #2117

There is also a lack of documentation on how to use the distance sensors, would be nice if someone could fix that too. Already mentioned in #1673.

@msftclas
Copy link

msftclas commented Feb 2, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@madratman
Copy link
Contributor

good catch, thanks!

@madratman madratman merged commit 67f2b6f into microsoft:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NameError: name 'DistanceSensorData' is not defined
3 participants
@sorensenmarius @msftclas @madratman