-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawn vehicles via RPC #2390
Spawn vehicles via RPC #2390
Conversation
9cde560
to
c911a6f
Compare
Need to rebase and test again. One thing I'm not sure about is how the Airsim.sln file is updated, it seems to indicate it's for Version 15, but we're now using 16 (2019), so doesn't it need to be updated? Or that it doesn't affect the build, etc? |
cd9538a
to
4de892e
Compare
Working on Linux, Pending Windows .vcxproj update, testing |
0afffdb
to
82476a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR @rajat2004! Once you're ready to submit this PR, I can take another look at this PR in case you've already addressed some of these comments in your next update.
b7d8b19
to
a38ce42
Compare
@zimmy87 and others also, If possible, could you test this on Windows as well, I'll also try to do so on my end. The changes in AirSim.sln & .vcxproj files are something which I have no idea about, these were already present in the old PR and have been carried forward here. |
c971ae2
to
137f867
Compare
I'm marking this PR as Ready for review since the first review comments as well as Unity non-implemented method has been tested, plus the HelloSpawnedDrones and the Python script (See video in PR description for the behaviour of HelloSpawnedDrones). The Python script could be enhanced a bit though
|
Hi @rajat2004, as per updating HelloSpawnedDrones.vcxproj and HelloSpawnedDrones.vcxproj, I've made a update to both these files in a commit here in my own AirSim fork that you can feel free to copy into this PR. With this commit, I'm able to build HelloSpawnedDrones from the AirSim solution locally, however this is breaking the Windows build check for me, so I'm still missing some dependencies in this commit. I will try and spend more time fixing the Windows build, and keep you updated once I've reached some resolution. |
@zimmy87 Sure, will bring that commit in later. I think it might be best to do that after all the problems have been figured out so can be done in one swoop. Once it's fixed, let me know and I can cherry-pick the commits onto my branch, or you could push to mine as well since maintainers can do that |
add project dependencies
remove duplicate declaration of registerPhysicsBody()
Thank you for the contribution @rajat2004! Tested latest version locally on Windows & Ubuntu and it's working & building just fine for me, so I am moving ahead with merging. |
@Roopesh-Bharatwaj-K-R Are you using the latest master rather than some other branch that isn't up to date and doesn't include this PR? Also, did you use |
@rajat2004 I Used import setup_path before import airsim. I'm not sure about the master.please give more details on this. |
Closes #2922
Rebased version of #1937
airsim_spawn_drones.mp4
Future improvement possible - pass JSON object as string for the vehicle settings
The example script is very minimal one right now, will need to improve it
Fun fact: I did test with 50 drones, AirSim was able to create them :) but my laptop was definitely struggling to keep up, also had a crash when closing the editor due to RPC error.