[UWP][Accessibility] Use element tag instead of access key for internal tracking #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
reviewed
Mar 6, 2020
| else | ||
| { | ||
| ComPtr<IElementTagContent> tagContent; | ||
| THROW_IF_FAILED(MakeAndInitialize<ElementTagContent>(&tagContent, nullptr, nullptr, nullptr, nullptr, false, true)); |
There was a problem hiding this comment.
what are all these nullptr and booleans? Could we get a comment to make it more descriptive? #Resolved
There was a problem hiding this comment.
They're non-relevant constructor parameters. But this is silly. Added a constructor that doesn't take all this to allow callers to construct a default tag content object and make the code a little clearer.
In reply to: 389054235 [](ancestors = 389054235)
almedina-ms
approved these changes
Mar 7, 2020
shalinijoshi19
added
Area-Accessibility
paulcam206
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #3819
Description
The WholeItemsPanel keeps track of which items have been marked as
"height":"stretch"in order to render them properly. In order to do this, the code was stashing an identifier in theAccessKeyproperty of the xaml elements (#1377). Unfortunately, that was causing access keys to show up in the UI when the user presses 'Alt'.Updated the code to use the
Tagproperty to handle this internal tracking, as that is a place for custom data that won't have a UI impact. Because we're already using the Tag property for a variety of purposes, added theIsStretchableproperty to the existingElementTagContenttype.How Verified
Confirmed that the card from bug #3819 no longer generates an access key. Verified existing VerticalStretch cards still render correctly.
Microsoft Reviewers: Open in CodeFlow