Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick fix for issue #3819 for 1.2.8 patch release #3887

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

shalinijoshi19
Copy link
Member

@shalinijoshi19 shalinijoshi19 commented Mar 27, 2020

  • [UWP][Accessibility] Use element tag instead of access key for internal tracking.

Related Issue

Fixes #3819

Description

Cherry-Pick fix for issue #3819 for 1.2.8 patch release

How Verified

  1. Local build succeeded where I was able to launch the corresponding UWP visualizer, use the card from the original issue and verify that pressing "Alt" wouldn't result in a '0' key showing up.
Microsoft Reviewers: Open in CodeFlow

* [UWP][Accessability] Use element tag instead of access key for internal tracking.

* CR feedback
@paulcam206
Copy link
Member

looks good except for the build failures from areas needing updates :)

@shalinijoshi19 shalinijoshi19 changed the title Cherry-Pick Issue #3820 for 1.2.8 patch release Cherry-Pick fix for issue #3819 for 1.2.8 patch release Mar 28, 2020
@shalinijoshi19
Copy link
Member Author

@shalinijoshi19
Copy link
Member Author

shalinijoshi19 commented Mar 28, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@shalinijoshi19
Copy link
Member Author

@paulcam206 ideas on these -- https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=22443432&view=results ? Restart the build?

Apparently a rebuild did it.

@shalinijoshi19
Copy link
Member Author

@paulcam206 / @RebeccaAnne let me know if this version looks good to go and i'll go ahead and kick off a release build!

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shalinijoshi19 shalinijoshi19 merged commit ee9456d into release/1.2 Mar 30, 2020
@shalinijoshi19 shalinijoshi19 deleted the user/shalinijoshi19/1.2.8 branch March 30, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants