Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP][Accessibility] Unexpected access keys appearing for select actions #3819

Closed
RebeccaAnne opened this issue Mar 5, 2020 · 1 comment · Fixed by #3820
Closed

[UWP][Accessibility] Unexpected access keys appearing for select actions #3819

RebeccaAnne opened this issue Mar 5, 2020 · 1 comment · Fixed by #3820
Labels
Area-Accessibility Bugs around feature accessibility Bug Platform-XAML Bugs or features related to Xaml Renderer

Comments

@RebeccaAnne
Copy link
Contributor

Platform

What platform is your issue or question related to? (Delete other platforms).

  • UWP

Details

When alt is pressed on a card containing a select action on a container with stretch height, an access key of '0' appears. This is unexpected, can lead to many select actions with the same access key, and can interfere with access keys set by the host app.

Example:
The below card renders as follows:
image

When the user presses 'Alt' a '0' access key appears
image

{
	"type": "AdaptiveCard",
	"version": "1.2",
	"body": [
		{
			"type": "Container",
			"items": [
				{
					"type": "TextBlock",
					"text": "This is a select action in a container with stretch"
				}
			],
			"selectAction": {
				"type": "Action.Submit",
				"title": "Submit action"
			},
			"height": "stretch"
		}
	]
}
@RebeccaAnne RebeccaAnne added the Bug label Mar 5, 2020
@ghost ghost added the Triage-Needed label Mar 5, 2020
@ghost ghost added the Status-In Code Review label Mar 5, 2020
@ghost ghost added Status-Fixed and removed Triage-Needed labels Mar 9, 2020
@shalinijoshi19 shalinijoshi19 added Area-Accessibility Bugs around feature accessibility MsftCortana-Integration Platform-XAML Bugs or features related to Xaml Renderer labels Mar 13, 2020
shalinijoshi19 added a commit that referenced this issue Mar 30, 2020
* Cherry-Pick Issue # 3820 for 1.2.8 patch release

* [UWP][Accessability] Use element tag instead of access key for internal tracking.

* CR feedback

* Updating custom.props to 1.2.8

* BUILD: Address build failures

Co-authored-by: RebeccaAnne <[email protected]>
@ghost
Copy link

ghost commented Apr 6, 2020

🎉[email protected] has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Bug Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
2 participants