perf: write out log line with time-prefix as one string to avoid holding locks #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing locks Earlier implementation in #35 can loop while holding the lock, which is not a good idea, and composing prefix+line into one GString is simpler anyway. Using glib datetime and string formatting also allows to simplify implementation.
thebaptiste
approved these changes
Feb 9, 2024
|
Thanks again ! Is ok for you, no more important PR left at hand ? I have release 0.6.0 with your two first PR and my ugly fix, I intend to release 0.7.0 now. |
|
Yeah, nothing else actually useful. Thanks. |
|
Or actually one thing that maybe bothers me is that while glib funcs handle all errors for e.g. invalid strftime string, it ends up being not-specific "prefix is NULL", which should probably be handled with a special more descriptive message, like "problem with strftime on %s" removed here did. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…-prefix (#41) Sorry for not thinking of it in #40, but this should fix non-descriptive something-about-assert-NULL error for bad timestamp-prefix format to something like this: ``` (log_proxy:269749): log_proxy-CRITICAL **: 17:37:58.678: strftime failed for timestamp-prefix: % ``` A relatively minor fix, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier implementation in #35 can loop while holding the lock, which is not a good idea, and composing prefix+line into one GString is simpler anyway.
Using glib datetime and string formatting also allows to simplify implementation.