fix: build log_proxy command in wrapper as an argv array, don't use gshell parser #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix passing
-T "(null)"
to log_proxy introduced by #35 in a hopefully slightly more obvious/cleaner way, and fix #37.g_spawn_command_line_async() was replaced by g_spawn_async(), so that instead of earlier workflow of:
gchar **argv
.It's just "build argv, run it with g_spawn_async", which eliminates unnecessary template-and-parse-it-back round-trip, and fixes string-escaping issues introduced by it cleanly.
Alternative can be to build a dynamic string, using g_shell_quote where string arguments are passed-through, but that seems unnecessary when it's just immediately parsed back to argv array anyway, and more error-prone in general.
Also removed
glib/*
component includes at the top, as these are redundant with#include <glib.h>
which loads all of them, and are insufficient/incorrect otherwise anyway.