-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add -T/--timestamps (env LOGPROXY_TIMESTAMPS) option to prepend strftime to each line #35
feat: add -T/--timestamps (env LOGPROXY_TIMESTAMPS) option to prepend strftime to each line #35
Conversation
… strftime to each line
Many thanks you for your PR. |
Thanks. My bad wrt prefix arg, added an option to wrapper as an afterthought and didn't think to test it without prefix. |
I'm not the lead maintener of log_proxy (@thefab is very busy these days) and you're probably a better python developer than me ! Meantime I will release 0.6.0 with your new option (which by the way was in our roadmap since several years !) Thanks again |
It's C, not python, but yeah sure, I'll make a PR today or tomorrow. |
Yes C ! So I will wait for your PR before releasing. |
Might work to address
[ ] option to add a timestamp before each log line
in the README.Not sure if it's the best way to do it, but was easy enough to add this way, to address my own use-case.
Feel free to merge with any kind of edits and tweaks, preserving commit/attribution does not matter to me at all.
Thanks for making this small tool.
It's especially useful in modern non-shell invocations with a proper wrapper mode and configuration via env vars.