Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looting blacklist #881

Merged
merged 8 commits into from
Oct 5, 2024
Merged

looting blacklist #881

merged 8 commits into from
Oct 5, 2024

Conversation

divinity76
Copy link
Contributor

When "loot every item" is off, it will loot everything in the loot list.

When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on.

Related upstream issue: Vithrax/vBot#15

I have tried submitting this upstream too, but it seems vBot upstream is unmaintained: Vithrax/vBot#18

divinity76 and others added 3 commits September 17, 2024 10:15
When "loot every item" is off, it will loot everything in the loot list.

When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on.
@kokekanon
Copy link
Collaborator

kokekanon commented Oct 1, 2024

@divinity76

1) Should you change this text as well?

image

@onClick

Example
fix drop

it is just an example, I think it is inverted.

.\bot\vBot_4.8\targetbot\looting.lua

  ui.everyItem.onClick = function()
    ui.everyItem:setOn(not ui.everyItem:isOn())
    if ui.everyItem:isOn() then
      ui.labelToLoot:setText("Items to loot")
    else
      ui.labelToLoot:setText("Items to ignore")
    end
    TargetBot.save()
  end

.bot\vBot_4.8\targetbot\looting.otui

  Label
    id: labelToLoot
    margin-top: 5
    text: Items to loot
    text-align: center

you could also change the text on the button


2) I suggest changing the font, because the text exceeds the button.

image

to

  BotSwitch
    id: everyItem
    !text: tr("Loot every item, except these")
    font: small-9px <----
    margin-top: 2

image

@divinity76
Copy link
Contributor Author

@kokekanon that's better! thanks, added :)

@luanluciano93 luanluciano93 merged commit 38801cb into mehah:main Oct 5, 2024
10 checks passed
jordanhoare added a commit to tibia-oce/otclient that referenced this pull request Oct 11, 2024
* perf: Drawpool 3.1

more stability in FPS

* setting m_effectAlpha, m_missileAlpha to 1.f

* fix: display density on mapview

* feat: hud scale

* fix: Interface Anchors (mehah#862)

* feat: support directx

* improve: use egl v3

* small change in gc

* fix: memory leak in controller

* improve: organization of the project structure

* add new config to draw covered things

There are projects where this system doesn't work very well, so if your project is one of those, just set it to true to fix the tiles that aren't being drawn.

* feat: update background image and startup sound to use 13.40 cip files. Adjustments in options buttons order and logout button icon. (mehah#865)

* update UIGraph (need test)

* fix shader warning

* fix: console error due to shaders

* draw-covered-things to false

Note: Setting false will not draw objects that the client understands are covered. If for some reason a tile is not being drawn because your game is custom, set this property to true and this issue will be resolved.

* baseline updated (update your vcpkg)

git pull

* Revert "baseline updated (update your vcpkg)"

This reverts commit 8dda995.

* fix: mehah#867

* feat: extractTexture in framebuffer, Arch SS2 by default and cleanup

* fix: inverted texture in extractTexture

* html: support tag img

* perf: reducing locking, thus increasing performance a little.

* fix draw shader

* prevent crash in static text

* improve: add lua call protection

* perf: improve propagateOnMouseMove

* fix: bot item ondrop and analyzer loot channel (mehah#887)

* fix: outfit size , prevent ERROR: invalid thing (mehah#884)

Co-authored-by: Rodrigo Paixão <[email protected]>

* improve: HTTP login error handling to display login.php error messages (mehah#886)

* fix: compilation error on some pcs

* feat: full cyclopedia module (mehah#868)

* fix: game_store bugs. fix: mehah#873 (mehah#874)

* feat: Minimap GM teleport ( ctrl +shift + click on minimap) (mehah#885)

Co-authored-by: Luan Luciano <[email protected]>

* support "Mage" vocation (mehah#882)

several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED.

Without this fix, on those servers, vBot would constantly error out with Error: (...) concatenat voc: a nil value

* fix (mehah#900)

* improve parseOpenContainer and fix error with decoration kit (mehah#890)

* fix: optional display rarity colors in items . feature GameColorizedLootValue 12.00 (mehah#896)

* fix: crash getItems (mehah#892)

* looting blacklist (mehah#881)

When "loot every item" is off, it will loot everything in the loot list.

When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on.

* Fix black and red squares behaviors (mehah#902)


* Fix squares:
- Set black squares color to 1 instead of 0 so it's not treated as alpha
- Fix creaturesMark logic so red squares don't disappear when attacking and black squares show when attacked

* feat: display tier UI (GameThingUpgradeClassification) (mehah#895)

* feat: Vips Groups | fix issue: mehah#730 (mehah#908)

* fix: spacing for align bottom vertical layouts (mehah#909)

* Fix: mehah#901

---------

Co-authored-by: Renato Machado <[email protected]>
Co-authored-by: SkullzOTS <[email protected]>
Co-authored-by: Luan Luciano <[email protected]>
Co-authored-by: Felipe Muniz <[email protected]>
Co-authored-by: Rodrigo Paixão <[email protected]>
Co-authored-by: kokekanon <[email protected]>
Co-authored-by: divinity76 <[email protected]>
Co-authored-by: divinity76 <[email protected]>
Co-authored-by: OT Archive <[email protected]>
Co-authored-by: Marcin Jałocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants