Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buy button gamestore inactive even though you have enough coins in your account #873

Closed
3 of 5 tasks
dgprado-80 opened this issue Sep 12, 2024 · 11 comments
Closed
3 of 5 tasks

buy button gamestore inactive even though you have enough coins in your account #873

dgprado-80 opened this issue Sep 12, 2024 · 11 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@dgprado-80
Copy link

dgprado-80 commented Sep 12, 2024 •
edited
Loading

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

The buy button in gamestore is inactive even though you have enough coins in your account.
only Transferable Coins are working.
image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dgprado-80 dgprado-80 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 12, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Sep 12, 2024
@dgprado-80
Copy link
Author

I dont use transferable coins

@kokekanon
Copy link
Collaborator

but you have 0 points xd
I think the problem is that the module has the wrong icon.

13.40 cipsoft
image

@dgprado-80
Copy link
Author

image
My client cipsoft 1332. I dont use transferable coins.

@kokekanon
Copy link
Collaborator

:O how do I change that on the server side?

@dgprado-80
Copy link
Author

Man, I don't remember how I changed. some time ago. hahaha. I'm trying to remember to solve this problem. I'll tell you as soon as I remember.

@dgprado-80
Copy link
Author

i dont change notthing, i just dont add trasferable coins for players.

@dgprado-80
Copy link
Author

I just realized that if the character has enough balance in trabsferible coins, he can only buy them for normal coins. The problem appears to be that the price of items is being checked exclusively in transferable coins

@kokekanon kokekanon mentioned this issue Sep 12, 2024
Merged
8 tasks
@kokekanon
Copy link
Collaborator

kokekanon commented Sep 12, 2024 •
edited
Loading

try this #874

canary\data\modules\scripts\gamestore\gamestore.lua

if you want test :
image

@dgprado-80
Copy link
Author

dgprado-80 commented Sep 12, 2024 •
edited
Loading

:O how do I change that on the server side?

I made a small modification to the canary's game_store.lua so that the store would only work with normal coins and I changed it from:
                  if not offer.coinType then
                        offer.coinType = GameStore.CoinType.Transferable

para

                  if not offer.coinType then
                        offer.coinType = GameStore.CoinType.Coin

This excerpt is at the end of the line file 6723

@kokekanon
Copy link
Collaborator

test pr

@dgprado-80
Copy link
Author

dgprado-80 commented Sep 12, 2024 •
edited
Loading

test pr

Yes my Hero, its works. thxx

jordanhoare added a commit to tibia-oce/otclient that referenced this issue Oct 11, 2024
@jordanhoare @mehah
@SkullzOTS @luanluciano93 @MUN1Z @Nottinghster @kokekanon @divinity76 @OTArchive @nekiro
feat: merge upstream (#3)
2206d63 
* perf: Drawpool 3.1

more stability in FPS

* setting m_effectAlpha, m_missileAlpha to 1.f

* fix: display density on mapview

* feat: hud scale

* fix: Interface Anchors (mehah#862)

* feat: support directx

* improve: use egl v3

* small change in gc

* fix: memory leak in controller

* improve: organization of the project structure

* add new config to draw covered things

There are projects where this system doesn't work very well, so if your project is one of those, just set it to true to fix the tiles that aren't being drawn.

* feat: update background image and startup sound to use 13.40 cip files. Adjustments in options buttons order and logout button icon. (mehah#865)

* update UIGraph (need test)

* fix shader warning

* fix: console error due to shaders

* draw-covered-things to false

Note: Setting false will not draw objects that the client understands are covered. If for some reason a tile is not being drawn because your game is custom, set this property to true and this issue will be resolved.

* baseline updated (update your vcpkg)

git pull

* Revert "baseline updated (update your vcpkg)"

This reverts commit 8dda995.

* fix: mehah#867

* feat: extractTexture in framebuffer, Arch SS2 by default and cleanup

* fix: inverted texture in extractTexture

* html: support tag img

* perf: reducing locking, thus increasing performance a little.

* fix draw shader

* prevent crash in static text

* improve: add lua call protection

* perf: improve propagateOnMouseMove

* fix: bot item ondrop and analyzer loot channel (mehah#887)

* fix: outfit size , prevent ERROR: invalid thing (mehah#884)

Co-authored-by: Rodrigo Paixão <[email protected]>

* improve: HTTP login error handling to display login.php error messages (mehah#886)

* fix: compilation error on some pcs

* feat: full cyclopedia module (mehah#868)

* fix: game_store bugs. fix: mehah#873 (mehah#874)

* feat: Minimap GM teleport ( ctrl +shift + click on minimap) (mehah#885)

Co-authored-by: Luan Luciano <[email protected]>

* support "Mage" vocation (mehah#882)

several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED.

Without this fix, on those servers, vBot would constantly error out with Error: (...) concatenat voc: a nil value

* fix (mehah#900)

* improve parseOpenContainer and fix error with decoration kit (mehah#890)

* fix: optional display rarity colors in items . feature GameColorizedLootValue 12.00 (mehah#896)

* fix: crash getItems (mehah#892)

* looting blacklist (mehah#881)

When "loot every item" is off, it will loot everything in the loot list.

When "loot every item" is on, it will loot everything that is not in the loot list, effectively making the loot list a blacklist when "loot every item" is on.

* Fix black and red squares behaviors (mehah#902)


* Fix squares:
- Set black squares color to 1 instead of 0 so it's not treated as alpha
- Fix creaturesMark logic so red squares don't disappear when attacking and black squares show when attacked

* feat: display tier UI (GameThingUpgradeClassification) (mehah#895)

* feat: Vips Groups | fix issue: mehah#730 (mehah#908)

* fix: spacing for align bottom vertical layouts (mehah#909)

* Fix: mehah#901

---------

Co-authored-by: Renato Machado <[email protected]>
Co-authored-by: SkullzOTS <[email protected]>
Co-authored-by: Luan Luciano <[email protected]>
Co-authored-by: Felipe Muniz <[email protected]>
Co-authored-by: Rodrigo Paixão <[email protected]>
Co-authored-by: kokekanon <[email protected]>
Co-authored-by: divinity76 <[email protected]>
Co-authored-by: divinity76 <[email protected]>
Co-authored-by: OT Archive <[email protected]>
Co-authored-by: Marcin Jałocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kokekanon @dgprado-80