Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing old OpenMDAO build #406

Merged
merged 4 commits into from
May 9, 2023
Merged

Fixing old OpenMDAO build #406

merged 4 commits into from
May 9, 2023

Conversation

kanekosh
Copy link
Contributor

@kanekosh kanekosh commented May 8, 2023

Purpose

NOTE: RTD build is currently failing, and I believe this will fix the issue. This fix is not released yet so we'll wait for a while.

Fixed the build issue of the oldest OpenMDAO.

In the oldest build, we've been failing to build wheel for OpenMDAO (I don't know exactly why, but we don't need to care about it because the latest build doesn't have this error). Then, the previous versions of pip switch to setup.py install which works, but the latest pip deprecated it, hence we're seeing the error.
In this PR, I pinned the pip version for the oldest build so that it switches to the setup.py install method to build OM. This workaround does not affect the latest build.

Copied from an old build log:

 DEPRECATION: openmdao was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at https://github.com/pypa/pip/issues/8368

Expected time until merged

In a few days. Should be merged before #405

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #406 (b2618b3) into main (966f8dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         103      103           
  Lines        6412     6412           
=======================================
  Hits         6058     6058           
  Misses        354      354           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kanekosh kanekosh marked this pull request as ready for review May 9, 2023 14:56
@kanekosh kanekosh requested a review from a team as a code owner May 9, 2023 14:56
@eytanadler eytanadler merged commit dcdb76b into main May 9, 2023
@kanekosh kanekosh deleted the om_build branch May 17, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants