Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated function from plot_wing #408

Closed
wants to merge 7 commits into from
Closed

Remove deprecated function from plot_wing #408

wants to merge 7 commits into from

Conversation

eytanadler
Copy link
Collaborator

Purpose

Addresses #407 by replacing cr.system_options with cr.list_model_options(). PR #406 should be merged first.

Expected time until merged

A week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner May 9, 2023 14:05
@eytanadler eytanadler requested review from lamkina and kanekosh May 9, 2023 14:05
@eytanadler eytanadler closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamkina lamkina Awaiting requested review from lamkina lamkina is a code owner automatically assigned from mdolab/openaerostruct_maintainers

@kanekosh kanekosh Awaiting requested review from kanekosh kanekosh is a code owner automatically assigned from mdolab/openaerostruct_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eytanadler @kanekosh