-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update: solvers and parallel multipoint analysis #405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 94.47% 94.52% +0.04%
==========================================
Files 103 103
Lines 6412 6412
==========================================
+ Hits 6058 6061 +3
+ Misses 354 351 -3 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great Shugo, thanks so much for adding detailed docs! I learned a lot just by reading these. It looks like a lot of comments, but most are just small grammatical changes.
A separate problem though, do you have any idea what's going on with the build? Something related to the OpenMDAO install seems to be failing. It's definitely not your fault because the same error showed up in the biweekly build that ran recently.
@eytanadler Thanks for catching a lot of types and errors! |
Sounds good! I'm also not sure what's going on with the RTD build, especially since it worked initially for this PR and you haven't changed anything since. |
If you don't mind, could you also bump the codecov action to v3 in the github actions file in this PR? Seems like there have been recurring problems recently (but not always), and updating the action might help. |
Purpose
testflo
frompytest
to run the MPI testNOTE: the MPI test does not work with the oldest python/package versions, and I could not fix that. For now, we only run the MPI test on the latest and not on the oldest. This is why the yml looks a little messy.
Expected time until merged
A week
Type of change
Testing
I added a new regression test
test_multipoint_parallel
.Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable