Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(TouchList) Add Safari Desktop to supporting browsers; add version for Safari Mobile #8848

Merged
merged 3 commits into from
Jan 26, 2021
Merged

(TouchList) Add Safari Desktop to supporting browsers; add version for Safari Mobile #8848

merged 3 commits into from
Jan 26, 2021

Conversation

strarsis
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

iOS Desktop browser now supports TouchList according to the Apple official documentation for TouchList: https://developer.apple.com/documentation/webkitjs/touchlist (version 10.1+).
The documentation also states the minimum version of Safari iOS (Mobile) for TouchList: version 2.0+.

@strarsis strarsis mentioned this pull request Jan 24, 2021
Closed
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 24, 2021
@strarsis
Copy link
Contributor Author

OK, ready to merge. 👍

ddbeck
ddbeck requested changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @strarsis and thanks for this PR. I see that it's your first to the project—welcome!

This change looks fine as-is, but I have a suggestion to expand this: can you apply the versions to the item and length subfeatures too? The linked docs report the same versions for those too, so it looks like we can get three corrections for the price of one here.

Thank you again!

@strarsis
Copy link
Contributor Author

@ddbeck: 34d67f4

ddbeck
ddbeck approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit f064f75 into mdn:master Jan 26, 2021
@strarsis
Copy link
Contributor Author

@ddbeck: And after merging the docs will be rebuilt (and deployed)? https://developer.mozilla.org/en-US/docs/Web/API/TouchList

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 27, 2021

@strarsis Changes merged go into the next release of @mdn/browser-compat-data (planned for tomorrow and most Thursdays) and MDN usually picks up those changes the next day. I'd expect the page to be regenerated with the new compat data on Friday, January 29.

germain-gg pushed a commit to germain-gg/browser-compat-data that referenced this pull request Feb 1, 2021
Merge remote-tracking branch 'upstream/master' into data/picture-in-p…
e6ce8bf 
…icture

* upstream/master: (1123 commits)
  Remove Chromium 89 from String.at / Array.at / TypedArray.at (mdn#8869)
  Add worker_support info for CacheStorage (mdn#8783)
  Remove several needless "Enabled by default" notes (mdn#8899)
  Add HTML global attribute nonce (mdn#8764)
  api.Navigator.vibrate - Firefox for Android doesn't vibrate (mdn#7172)
  Mark MediaSource's onsourceclose as not supported in Firefox (mdn#8881)
  Update Florian's ownership (mdn#8893)
  Mention fix for Chrome's broken PDF loading (mdn#8867)
  Fill out Chrome data for html.elements.source.{sizes,srcset} (mdn#8889)
  Weekly data release for 2021-01-28
  Add text-decoration-thickness for Opera 73+ (mdn#8872)
  Update :is and :where pseudo-classes for Chrome (mdn#7375)
  Add note re Safari <9 partial srcset/sizes support (mdn#7353)
  Update data for when href (not xlink:href) can be used in SVG (mdn#6603)
  Add top-level await (mdn#8807)
  TouchList: Add Safari Desktop and Safari iOS versions (mdn#8848)
  Update Firefox versions to account for Firefox 85 release (mdn#8864)
  Fix page_action.show_matches support for Android (mdn#8844)
  Update Safari support for devicechange_event (mdn#8863)
  Add HTTPS-only to privacy.network (mdn#8830)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strarsis @ddbeck