Update top-level await for Chrome 89 #8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating
Updating
github-actions
bot
added
the
data:js
ddbeck
requested changes
Jan 22, 2021
There was a problem hiding this comment.
Hi @Rumyra, while reviewing the linked bug I saw that this is shipping enabled-by-default in 89 (on all platforms). Can we include that as well? Here are some notes that might help:
- Chrome: new support statement for Chrome 89
- Chrome Android: copy all from Chrome
- Opera: copy flagged support statement from Chrome, but use version 73 instead (too early to show unflagged data for Opera)
- Opera Android: leave as
false(doesn't support flags, too early for unflagged) - WebView: copy unflagged version 89 support statement only (doesn't support flags)
|
Thanks @ddbeck a quick question: Chrome new support statement - do we keep the existing flagged statement as well? |
|
If allowed by the BCD rules it should be removed. After a feature arrives
in stable, Chrome advises against using anything other for developer
experimentation, and against asking users to flip flags. Any bugs found in
the flagged version will be fixed in stable only (assuming they weren't
found before the feature went to stable).
Joe Medley | Technical Writer, Chrome DevRel | [email protected] |
816-678-7195
*If an API's not documented it doesn't exist.*
…On Fri, Jan 22, 2021 at 8:51 AM Ruth John ***@***.***> wrote:
Thanks @ddbeck <https://github.com/ddbeck> a quick question: Chrome new
support statement - do we keep the existing flagged statement as well?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8807 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6S7C3QA6KU5Q4T4O2ILKLS3GUJ7ANCNFSM4WKTB7PA>
.
|
|
Thanks @jpmedley 👍 |
What @jpmedley suggests is permissible in this case since we never added the flag data to begin with, though it's a rather exceptional case. We never got consensus about what to do with so-called "dead flags" (see #3318), which means that, for flags which are already checked in, you can't remove flags except under narrow circumstances (see #6018). |
Co-authored-by: Daniel D. Beck <[email protected]>
|
Thank so much @ddbeck that's really helpful 👍 |
germain-gg
pushed a commit
to germain-gg/browser-compat-data
that referenced
this pull request
Feb 1, 2021
…icture * upstream/master: (1123 commits) Remove Chromium 89 from String.at / Array.at / TypedArray.at (mdn#8869) Add worker_support info for CacheStorage (mdn#8783) Remove several needless "Enabled by default" notes (mdn#8899) Add HTML global attribute nonce (mdn#8764) api.Navigator.vibrate - Firefox for Android doesn't vibrate (mdn#7172) Mark MediaSource's onsourceclose as not supported in Firefox (mdn#8881) Update Florian's ownership (mdn#8893) Mention fix for Chrome's broken PDF loading (mdn#8867) Fill out Chrome data for html.elements.source.{sizes,srcset} (mdn#8889) Weekly data release for 2021-01-28 Add text-decoration-thickness for Opera 73+ (mdn#8872) Update :is and :where pseudo-classes for Chrome (mdn#7375) Add note re Safari <9 partial srcset/sizes support (mdn#7353) Update data for when href (not xlink:href) can be used in SVG (mdn#6603) Add top-level await (mdn#8807) TouchList: Add Safari Desktop and Safari iOS versions (mdn#8848) Update Firefox versions to account for Firefox 85 release (mdn#8864) Fix page_action.show_matches support for Android (mdn#8844) Update Safari support for devicechange_event (mdn#8863) Add HTTPS-only to privacy.network (mdn#8830) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A checklist to help your pull request get merged faster:
Updating info for top level await
https://bugs.chromium.org/p/v8/issues/detail?id=9344
This works for me in Chrome 87 with #enable-javascript-harmony flag enabled
Passed
mdn/content#297